This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Change action type name for use shipping as billing option #7695
Merged
tarunvijwani
merged 2 commits into
trunk
from
update/action-type-name-for-use-shipping-as-billing
Nov 21, 2022
Merged
Change action type name for use shipping as billing option #7695
tarunvijwani
merged 2 commits into
trunk
from
update/action-type-name-for-use-shipping-as-billing
Nov 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarunvijwani
added
block: checkout
Issues related to the checkout block.
type: task
The issue is an internally driven task (e.g. from another A8c team).
labels
Nov 16, 2022
The release ZIP for this PR is accessible via:
|
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the |
TypeScript Errors ReportFiles with errors: 431 🎉 🎉 This PR does not introduce new TS errors. |
Size Change: 0 B Total Size: 991 kB ℹ️ View Unchanged
|
alexflorisca
approved these changes
Nov 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @tarunvijwani, let's ship it!
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
Nov 18, 2022
tarunvijwani
deleted the
update/action-type-name-for-use-shipping-as-billing
branch
November 21, 2022 14:04
tarunvijwani
pushed a commit
that referenced
this pull request
Nov 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
block: checkout
Issues related to the checkout block.
type: task
The issue is an internally driven task (e.g. from another A8c team).
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a part of #6625. We had the action type named
SET_SHIPPING_ADDRESS_AS_BILLING_ADDRESS
and we were usinguseShippingAsBilling
state variable in Checkout block. Either of them needed to be renamed to reflected better connection between them.Changes in the PR:
Renamed the action type from
SET_SHIPPING_ADDRESS_AS_BILLING_ADDRESS
toSET_USE_SHIPPING_AS_BILLING
in Checkout block.Accessibility
prefers-reduced-motion
Other Checks
Testing
Automated Tests
User Facing Testing
WooCommerce Visibility
Changelog