This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Remove CustomerDataContext #7686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubikuserbot
requested review from
a team and
wavvves
and removed request for
a team
alexflorisca
added
type: refactor
|
The release ZIP for this PR is accessible via: |
TypeScript Errors ReportFiles with errors: 429 🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: -213 B (0%) Total Size: 970 kB
ℹ️ View Unchanged
|
I don't see any requests being made while I update address details 🤔 |
|
@wavvves Should have been more specific sorry, you need to edit the postcode, country or city fields - only these will trigger a batch update |
wavvves
approved these changes
Nov 23, 2022
|
@alexflorisca Tested it out and went through changes. Looks ok, but maybe bring in @opr to have a quick second set of eyes to ensure nothing gets broken? |
opr
approved these changes
Nov 23, 2022
…ommerce/woocommerce-blocks into update/remove-customer-data-context
Script Dependencies ReportThe
This comment was automatically generated by the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to recent changes (data store refactor and #5817), the customer data context has become redundant. What was previously stored here now lives in the cart store and can be accessed directly. This PR removes the CustomerDataContext and associated hook -
useCustomerData().Fixes #6108
User Facing Testing
The following functionality requires smoke testing:
User Testing instructions
Use same address for billingcheckbox. Ensure the billing address shows and hides when you tick this boxWooCommerce Visibility