This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Fix: Product Query editor preview with Stock Status setting #7682
Merged
+6
−3
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
18de845
fix: update the rest query to include stock status meta query, so edi…
dinhtungdu 4306b2f
bot: update checkstyle.xml
github-actions[bot] e2a170f
Merge branch 'trunk' into fix/product-query-preview-stock-status
dinhtungdu 630a6c0
Merge branch 'trunk' into fix/product-query-preview-stock-status
dinhtungdu b17417e
Merge branch 'trunk' into fix/product-query-preview-stock-status
dinhtungdu c456f87
refactor the get_stock_status_query to return an empty array for empt…
dinhtungdu 459d617
Merge branch 'trunk' into fix/product-query-preview-stock-status
dinhtungdu c0e1dbd
Merge branch 'trunk' into fix/product-query-preview-stock-status
dinhtungdu 8c53a13
update stock query handling to align with attribute query
dinhtungdu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
refactor the get_stock_status_query to return an empty array for empt…
…y argument
commit c456f87436a77afa86b9d6296833e223a64c85e3
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I see what you mean. We need to decide what is the approach we take at least within this class. I don't have a super strong opinion. Given the conversation in #7796, what do you think of the middle-ground I proposed there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just commented there, I will update this PR following what we do with yours.