This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Product button: Fix 'In cart' button localization. #7504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #7494. Co-authored-by: Niels Lange <[email protected]>
rubikuserbot
requested review from
a team and
sunyatasattva
and removed request for
a team
danieldudzic
added
focus: i18n
|
The release ZIP for this PR is accessible via: |
|
Size Change: 0 B Total Size: 993 kB ℹ️ View Unchanged
|
|
Tagging @gigitux here. The change to return It seems this change could cause a cycle of back-and-forth reversions, so maybe @gigitux can clarify why that change was required and how can we restore l12n without undoing support for Product Query. |
|
Thanks @sunyatasattva, for tagging me! I made that change because when this block is used in the PQ, we generate the markup on the server side, so it isn't necessary to load JS assets. But if we break custom translations, we have to find another solution. We are using this approach for all atomic blocks :/ |
|
Well, many atomic blocks don't use translations, right? Like Product Image. But we need to be aware of those which do. Do you suggest to merge this PR and create an issue on the Product Query epic to figure out an alternative solution? I think it's more important to fix the breaking translations now and merge this, as our work on the PQ is not public yet. What do you think? |
|
@sunyatasattva It makes sense. We can investigate this issue in the following weeks 👍 I will open an issue about this! |
sunyatasattva
approved these changes
Oct 27, 2022
senadir
pushed a commit
to senadir/woocommerce-blocks
that referenced
this pull request
Nov 12, 2022
Fixes woocommerce#7494. Co-authored-by: Niels Lange <[email protected]>
dinhtungdu
added a commit
that referenced
this pull request
Dec 16, 2022
To ensure no JS for product elements inside Product Query block is loaded.
7 tasks
dinhtungdu
added a commit
that referenced
this pull request
Dec 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue with the "x in cart" text not translating within the All products block.
Fixes #7494.
Co-authored-by: Niels Lange [email protected]
Screenshots
Testing
%d in cartwithin the WooCommerce core plugin language files.Automated Tests
User Facing Testing
Same as the above.
WooCommerce Visibility
Changelog