Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Add temporary workaround to fix inserting Cart block in WordPress.com #7367

Merged
merged 3 commits into from
Oct 11, 2022
Merged

Add temporary workaround to fix inserting Cart block in WordPress.com #7367

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b7a2e3
remove problematic actions as deps
senadir Oct 11, 2022
50346b3
add inline docs
senadir Oct 11, 2022
63b7511
add todo comment
senadir Oct 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions assets/js/blocks/cart-checkout-shared/use-forced-layout.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,9 @@ export const useForcedLayout = ( {
insertBlock( newBlock, position, clientId, false );
setForcedBlocksInserted( forcedBlocksInserted + 1 );
},
[ clientId, insertBlock, forcedBlocksInserted ]
// We need to skip insertBlock here due to a cache issue in wordpress.com that causes an inifinite loop, see https://github.com/Automattic/wp-calypso/issues/66092 for an expanded doc.
// eslint-disable-next-line react-hooks/exhaustive-deps
[ clientId, forcedBlocksInserted ]
);

const lockedBlockTypes = useMemo(
Expand Down Expand Up @@ -144,11 +146,10 @@ export const useForcedLayout = ( {
break;
}
} );
}, [
clientId,
innerBlocks,
lockedBlockTypes,
replaceInnerBlocks,
appendBlock,
] );
/*
We need to skip replaceInnerBlocks here due to a cache issue in wordpress.com that causes an inifinite loop, see https://github.com/Automattic/wp-calypso/issues/66092 for an expanded doc.
@todo Add replaceInnerBlocks and insertBlock after fixing https://github.com/Automattic/wp-calypso/issues/66092
*/
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [ clientId, innerBlocks, lockedBlockTypes, appendBlock ] );
};