This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Products by Rating: Add inner block support #7362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubikuserbot
requested review from
a team and
tjcafferkey
and removed request for
a team
|
The release ZIP for this PR is accessible via: |
|
Size Change: +3.3 kB (0%) Total Size: 965 kB
ℹ️ View Unchanged
|
tjcafferkey
reviewed
Oct 11, 2022
tjcafferkey
reviewed
Oct 11, 2022
tjcafferkey
reviewed
Oct 11, 2022
tjcafferkey
reviewed
Oct 11, 2022
|
@tjcafferkey The |
Maybe I need to look into it further but my understand of the work done on this pr #6978 was to separate headings from the filters. But in this case the heading still exists within the filter? The other filters it makes sense because we need to support and migrate users who are already using it but since this is a new block we shouldn't have that problem? |
Script Dependencies ReportThe
This comment was automatically generated by the |
dinhtungdu
reviewed
Oct 12, 2022
| ), | ||
| headingLevel: 3, | ||
| } ), | ||
| transform: () => createBlock( 'woocommerce/rating-filter' ), |
There was a problem hiding this comment.
The transform function doesn't work anymore. I noticed the same happens to the Price Filter block. We should review the transform function for all filter blocks after this PR.
Thank you for the review, the star issue is unrelated to the block: #7167 |
gigitux
approved these changes
Oct 12, 2022
There was a problem hiding this comment.
I relied on @dinhtungdu's comments.
Besides this comment that it will be addressed in a dedicated PR, LGTM 🚢
opr
added
block: filter by rating
sunyatasattva
pushed a commit
that referenced
this pull request
Oct 26, 2022
* Products by Rating: Add InnerBlock support for Ratings * Product by Ratings: Register Ratings filter as an InnerBlock * Product by Rating: Fix active rating filters bug * Products by Rating: Remove all heading references * Products by Rating: Minor code fixes * Products by Rating: Fix ESlint errors * Products by Rating: Fix dependency placement
senadir
pushed a commit
to senadir/woocommerce-blocks
that referenced
this pull request
Nov 12, 2022
* Products by Rating: Add InnerBlock support for Ratings * Product by Ratings: Register Ratings filter as an InnerBlock * Product by Rating: Fix active rating filters bug * Products by Rating: Remove all heading references * Products by Rating: Minor code fixes * Products by Rating: Fix ESlint errors * Products by Rating: Fix dependency placement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A PR following #6978 updating the Filter by Ratings block to match the new InnerBlock standard.
The only difference: there's no upgrade path included, as this has been behind an experimental flag.
It also adds the Ratings filter to the filters block pattern.
Testing
Automated Tests
User Facing Testing
Insert new blocks:
WooCommerce Visibility
Changelog