Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Correct block name and description #7354

Merged
merged 4 commits into from
Oct 11, 2022
Merged

Correct block name and description #7354

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5744f08
Correct block name and description
dinhtungdu Oct 10, 2022
ed5417e
remove duplicated description for controls blocks
dinhtungdu Oct 10, 2022
9dbac32
remove duplicated title and desc
dinhtungdu Oct 10, 2022
c030e67
Revert "remove duplicated description for controls blocks"
dinhtungdu Oct 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion assets/js/blocks/active-filters/block.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "woocommerce/active-filters",
"version": "1.0.0",
"title": "Active Product Filter Controls",
"title": "Active Product Filters Controls",
"description": "Display the currently active product filters.",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tjcafferkey We're using duplicated description for the filter controls block and the wrapper variation. What do you think about removing the description for controls blocks?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove the description for the control blocks since they only feature in the wrapper blocks (which have the same description). And you cannot add them via the inserter separately.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed in ed5417e

"category": "woocommerce",
"keywords": [ "WooCommerce" ],
Expand Down
2 changes: 1 addition & 1 deletion assets/js/blocks/attribute-filter/block.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "woocommerce/attribute-filter",
"version": "1.0.0",
"title": "Filter by Attribute Controls",
"description": "Allow customers to filter the grid by product attribute, such as color.",
"description": "Enable customers to filter the product grid by selecting one or more attributes, such as color.",
"category": "woocommerce",
"keywords": [ "WooCommerce" ],
"supports": {
Expand Down
8 changes: 4 additions & 4 deletions assets/js/blocks/filter-wrapper/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ registerBlockType( metadata, {
'woo-gutenberg-products-block'
),
description: __(
'Show the currently active product filters. Works in combination with other filters blocks.',
'Display the currently active product filters.',
'woo-gutenberg-products-block'
),
/**
Expand Down Expand Up @@ -58,7 +58,7 @@ registerBlockType( metadata, {
name: 'price-filter',
title: __( 'Filter by Price', 'woo-gutenberg-products-block' ),
description: __(
'Allow customers to filter products by price range.',
'Enable customers to filter the product grid by choosing a price range.',
'woo-gutenberg-products-block'
),
isActive: ( attributes ) =>
Expand All @@ -83,7 +83,7 @@ registerBlockType( metadata, {
name: 'stock-filter',
title: __( 'Filter by Stock', 'woo-gutenberg-products-block' ),
description: __(
'Allow customers to filter the grid by products stock status.',
'Enable customers to filter the product grid by stock status.',
'woo-gutenberg-products-block'
),
isActive: ( attributes ) =>
Expand All @@ -108,7 +108,7 @@ registerBlockType( metadata, {
name: 'attribute-filter',
title: __( 'Filter by Attribute', 'woo-gutenberg-products-block' ),
description: __(
'Allow customers to filter the grid by product attribute, such as color.',
'Enable customers to filter the product grid by selecting one or more attributes, such as color.',
'woo-gutenberg-products-block'
),
isActive: ( attributes ) =>
Expand Down
2 changes: 1 addition & 1 deletion assets/js/blocks/stock-filter/block.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "woocommerce/stock-filter",
"version": "1.0.0",
"title": "Filter by Stock Controls",
"description": "Allow customers to filter the grid by products stock status.",
"description": "Enable customers to filter the product grid by stock status.",
"category": "woocommerce",
"keywords": [ "WooCommerce" ],
"supports": {
Expand Down