This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add default style to link-button mixin #7340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was identified that we currently have 3 different behaviors for links used in the application. In issue #1778, it was discussed a set of good practices that we should follow in order to obtain consistency between links. Currently, the link-button mixin is already used by the 'Clear all' button in the Active Filters block, so the idea was to increment it with a common pattern (font size small, font-weight normal, underlined by default and not underlined when on hover) that can be reused by other components (for example FilterResetButton). * Change link-button mixin to make it attend the expected default style for links * Replace text-button with link-button mixin in FilterResetButton component
|
The release ZIP for this PR is accessible via: |
|
Size Change: +197 B (0%) Total Size: 959 kB
ℹ️ View Unchanged
|
tjcafferkey
approved these changes
Oct 10, 2022
There was a problem hiding this comment.
Great PR write-up and testing instructions @thealexandrelara ! This PR LGTM! 🚢
tjcafferkey
added
block-type: filter blocks
|
@thealexandrelara I have also just added a few labels to this PR, and assigned you to it for good practice. Other than that, great job! |
|
I can also see that the failing tests are related to the Mini Cart, these are being looked into separately so this PR is safe to be merged I think 😃 |
wavvves
deleted the
style/consistent-underlined-links-for-filter-blocks
branch
|
Nice improvement and congrats on your first PR, @thealexandrelara! @thealexandrelara @tjcafferkey I have just one question (sorry if that was discussed somewhere else and I missed it), but is it expected that the font size changes are applied to all consumers of
(I know it's hard to see 😅 but I wonder if |
|
Good catch here @Aljullu , you might be right. @thealexandrelara how do you feel about reopening this and using the SCSS extend functionality instead for a new mixin to get the desired outcome specifically for the filter links? cc'ing @wavvves incase you need to revert for the release. |
tjcafferkey
restored the
style/consistent-underlined-links-for-filter-blocks
branch
Nice catch @Aljullu, I didn't release it was being used in a scope other than filter blocks 😓
That's alright I can reopen this one. Any suggestion about the new mixin name? Maybe |
I think that makes sense. Might need to also coordinate with @wavvves to ensure this does go into the release but that shouldn't be a problem 😃 |
3 tasks
|
@tjcafferkey I reopened and added it to the milestone, and I'll cherrypick it tomorrow along with the other task 👍🏼 |
danieldudzic
pushed a commit
that referenced
this pull request
Oct 11, 2022
It was identified that we currently have 3 different behaviors for links used in the application. In issue #1778, it was discussed a set of good practices that we should follow in order to obtain consistency between links. Currently, the link-button mixin is already used by the 'Clear all' button in the Active Filters block, so the idea was to increment it with a common pattern (font size small, font-weight normal, underlined by default and not underlined when on hover) that can be reused by other components (for example FilterResetButton). * Change link-button mixin to make it attend the expected default style for links * Replace text-button with link-button mixin in FilterResetButton component
senadir
pushed a commit
to senadir/woocommerce-blocks
that referenced
this pull request
Nov 12, 2022
It was identified that we currently have 3 different behaviors for links used in the application. In issue woocommerce#1778, it was discussed a set of good practices that we should follow in order to obtain consistency between links. Currently, the link-button mixin is already used by the 'Clear all' button in the Active Filters block, so the idea was to increment it with a common pattern (font size small, font-weight normal, underlined by default and not underlined when on hover) that can be reused by other components (for example FilterResetButton). * Change link-button mixin to make it attend the expected default style for links * Replace text-button with link-button mixin in FilterResetButton component
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was identified that we currently have 3 different behaviors for links used in the application. In issue #1778, it was discussed a set of good practices that we should follow in order to obtain consistency between links.
Currently, the link-button mixin is already used by the 'Clear all' button in the Active Filters block, so the idea was to increment it with a common pattern (font size small, font-weight normal, underlined by default and not underlined when on hover) that can be reused by other components (for example FilterResetButton).
Accessibility
Screenshots
User Facing Testing
none(no underline) while the other properties remain the same:Changelog