This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Hide the shipping address form from the Checkout when the "Force shipping to the customer billing address" is enabled #7268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: |
|
Size Change: +171 B (0%) Total Size: 917 kB
ℹ️ View Unchanged
|
tarunvijwani
changed the title
tarunvijwani
changed the title
tarunvijwani
changed the title
tarunvijwani
added
block: checkout
tarunvijwani
changed the title
tarunvijwani
changed the title
tarunvijwani
changed the title
rubikuserbot
requested review from
a team and
wavvves
and removed request for
a team
wavvves
approved these changes
Oct 6, 2022
tarhi-saad
approved these changes
Oct 7, 2022
There was a problem hiding this comment.
Thank you, @tarunvijwani, for working on this PR! And thank you, @wavvves, for the review! I tested the PR as well, and it works as expected! I'll merge the PR since @tarunvijwani is AFK and this need to be ready for next week's release! 🙌
|
I checked the failed E2E and JS Lint tests, which seem unrelated to this PR. We can see the same JS lint error on previous commits. The failing E2E test is a flaky one. I've run it locally, and it passed successfully! |
|
@nielslange This might impact woocommerce/woocommerce#42623. Good to test this scenario as well. |
senadir
pushed a commit
to senadir/woocommerce-blocks
that referenced
this pull request
Nov 12, 2022
…ping to the customer billing address" is enabled (woocommerce#7268) * Hide shipping address form from the Checkout when forced billing address is enabled. * Update shipping address when billing address is changed * Display shipping options * Fixed needs shipping condition Co-authored-by: Saad Tarhi <[email protected]>
senadir
pushed a commit
to senadir/woocommerce-blocks
that referenced
this pull request
Nov 12, 2022
…ping to the customer billing address" is enabled (woocommerce#7268) * Hide shipping address form from the Checkout when forced billing address is enabled. * Update shipping address when billing address is changed * Display shipping options * Fixed needs shipping condition Co-authored-by: Saad Tarhi <[email protected]>
senadir
pushed a commit
to senadir/woocommerce-blocks
that referenced
this pull request
Nov 20, 2022
…ping to the customer billing address" is enabled (woocommerce#7268) * Hide shipping address form from the Checkout when forced billing address is enabled. * Update shipping address when billing address is changed * Display shipping options * Fixed needs shipping condition Co-authored-by: Saad Tarhi <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hides the shipping address form from the Checkout when the
Force shipping to the customer billing addressis enabled.Fixes #7219
Changes in the PR
Screenshots
Testing
Automated Tests
User Facing Testing
wp-admin/admin.php?page=wc-settings&tab=shipping§ion=optionspage.Force shipping to the customer billing addressoption and save the changes.WooCommerce Visibility
Performance Impact
Changelog