This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Prevent infinite loop when initialising the payments data store in the editor. #7256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opr
added
status: needs review
type: bug
rubikuserbot
requested review from
a team and
tarunvijwani
and removed request for
a team
|
The release ZIP for this PR is accessible via: |
alexflorisca
approved these changes
Sep 29, 2022
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
|
Size Change: 0 B Total Size: 959 kB ℹ️ View Unchanged
|
tarunvijwani
approved these changes
Oct 3, 2022
opr
force-pushed
the
fix/infinte-loop-payment-methods
branch
from
a084301 to
56eed6c
Compare
senadir
pushed a commit
to senadir/woocommerce-blocks
that referenced
this pull request
Nov 12, 2022
…e editor. (woocommerce#7256) * Unsubscribe the editor from changes when store is initialised * Use correct action to initialize payment store
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will ensure that the subscription to the
wc/store/payment-methodswhich was implemented to correctly display payment methods in the Checkout block in the editor is unsubscribed once the store is initialised.Previously, this was never unsubscribed so we saw errors like
RangeError: Maximum call stack size exceededascheckPaymentMethodsCanPaywas executed every time the store changed.Testing
Automated Tests
User Facing Testing
RangeError: Maximum call stack size exceededor similar appear.WooCommerce Visibility
Performance Impact
Changelog