This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add showRemoveItemLink filter to CartLineItemRow
#7242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a filter that will allow developers to set whether the link to remove a cartItem is visible
opr
added
status: needs review
focus: blocks
rubikuserbot
requested review from
a team and
wavvves
and removed request for
a team
|
The release ZIP for this PR is accessible via: |
opr
requested review from
a team
and removed request for
wavvves and
a team
opr
requested review from
a team,
nielslange and
senadir
and removed request for
a team
|
Size Change: +78 B (0%) Total Size: 916 kB
ℹ️ View Unchanged
|
…' into add/show-remove-item-link-filter
nielslange
approved these changes
Sep 29, 2022
There was a problem hiding this comment.
Great work, @opr! The PR works as expected. I'm pre-approving it, but regarding the documentation, I wonder if we should add an example similar to the ones seen in https://github.com/woocommerce/woocommerce-blocks/blob/ffdaab7815432c9fa8f256ceef873eccea14e724/docs/third-party-developers/extensibility/checkout-block/available-filters.md#examples.
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
|
Thanks @nielslange. I've added the example now! |
nielslange
approved these changes
Sep 30, 2022
There was a problem hiding this comment.
Thanks for adding the example, @opr! I'd say, let's ⛴ this change! 🙌
senadir
pushed a commit
to senadir/woocommerce-blocks
that referenced
this pull request
Nov 12, 2022
* Add showRemoveItemLink filter This is a filter that will allow developers to set whether the link to remove a cartItem is visible * Add test for showRemoveItemLink filter * Remove unnecessary quantity override * Move definition of cart to avoid hardcoding id value in filter * Updated documentation for `showRemoveItemLink` filter * available-filters.md tweak * available-filters.md tweak * Add example to filters for showRemoveItemLink * Remove whitespace Co-authored-by: Paulo Arromba <[email protected]> Co-authored-by: Niels Lange <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add a new filter to the Cart block, specifically in the
CartLineItemRowcomponent.The filter's name is
showRemoveItemLinkand is used to disable the visibility of theRemove itemtext.There are also unit tests and documentation changes included in this PR.
This PR does not add any changes to the StoreAPI to prevent removal because this something that should be handled by the extension that wants to implement the restriction. (It would be possible using the
woocommerce_remove_cart_itemhook.)Fixes #5415
Testing
Automated Tests
User Facing Testing
Remove itembutton showing up for a product calledBeaniedocs/third-party-developers/extensibility/checkout-block/available-filters.mdfile and ensure it is good, and the new text we added to describe the filter makes sense.WooCommerce Visibility
Performance Impact
Changelog