This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix use of sanitizeHTML #7231
Merged
Fix use of sanitizeHTML #7231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsingyuc
changed the title
|
The release ZIP for this PR is accessible via: |
|
Size Change: +60 B (0%) Total Size: 916 kB
ℹ️ View Unchanged
|
3 tasks
brianyu28
reviewed
Sep 27, 2022
There was a problem hiding this comment.
Thanks @hsingyuc! This looks good to me, though two thoughts:
- Since I'm less familiar with the
woocommerce-blocks, I'd like to get a second reviewer on this for another pair of eyes. Maybe @nielslange, since I see you worked on related code recently? - There's a lot of changes to
package-lock.jsonhere for what seems like a fairly small dev dependency change. I wonder if maybe yours was generated with a different version of npm than this repo normally uses?
|
Thank you for the feedbacks, @brianyu28!
Good idea.
I |
|
@brianyu28 I tried to remove |
nielslange
reviewed
Sep 28, 2022
There was a problem hiding this comment.
Thanks for working on this, @hsingyuc. I left one question, regarding removing dangerouslySetInnerHTML(), and one suggestions, regarding removing the object keys, based on your comment in #7147 (comment).
assets/js/base/context/providers/store-notices/components/store-notices-container.js
Show resolved
Hide resolved
|
@hsingyuc I just want to let you know that @alexflorisca is currently merging #6612. To avoid inconsistencies, please do not merge this PR until @alexflorisca is done with the other PR and is giving green light. Thanks in advance! 🙌 |
|
You can merge now, but you may have some conflicts. If you need a hand fixing them just let me know. |
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the |
opr
added
type: bug
opr
added
focus: blocks
|
@opr Thank you! |
6 tasks
senadir
pushed a commit
to senadir/woocommerce-blocks
that referenced
this pull request
Nov 12, 2022
* Remove object from sanitizeHTML return value * Import sanitizeHTML from utils * Fix dangerously set inner HTML format * Update package-lock * Update package-lock * Update package-lock * Update @types/dompurify version Co-authored-by: Thomas Roberts <[email protected]>
senadir
pushed a commit
to senadir/woocommerce-blocks
that referenced
this pull request
Nov 12, 2022
* Remove object from sanitizeHTML return value * Import sanitizeHTML from utils * Fix dangerously set inner HTML format * Update package-lock * Update package-lock * Update package-lock * Update @types/dompurify version Co-authored-by: Thomas Roberts <[email protected]>
senadir
pushed a commit
to senadir/woocommerce-blocks
that referenced
this pull request
Nov 20, 2022
* Remove object from sanitizeHTML return value * Import sanitizeHTML from utils * Fix dangerously set inner HTML format * Update package-lock * Update package-lock * Update package-lock * Update @types/dompurify version Co-authored-by: Thomas Roberts <[email protected]>
dependabot bot
added a commit
to senadir/woocommerce-blocks
that referenced
this pull request
Nov 20, 2022
* Remove object from sanitizeHTML return value * Import sanitizeHTML from utils * Fix dangerously set inner HTML format * Update package-lock * Update package-lock * Update package-lock * Update @types/dompurify version Co-authored-by: Thomas Roberts <[email protected]>
dependabot bot
added a commit
to senadir/woocommerce-blocks
that referenced
this pull request
Nov 20, 2022
* Remove object from sanitizeHTML return value * Import sanitizeHTML from utils * Fix dangerously set inner HTML format * Update package-lock * Update package-lock * Update package-lock * Update @types/dompurify version Co-authored-by: Thomas Roberts <[email protected]>
dependabot bot
added a commit
to senadir/woocommerce-blocks
that referenced
this pull request
Nov 20, 2022
* Remove object from sanitizeHTML return value * Import sanitizeHTML from utils * Fix dangerously set inner HTML format * Update package-lock * Update package-lock * Update package-lock * Update @types/dompurify version Co-authored-by: Thomas Roberts <[email protected]>
dependabot bot
added a commit
to senadir/woocommerce-blocks
that referenced
this pull request
Nov 20, 2022
* Remove object from sanitizeHTML return value * Import sanitizeHTML from utils * Fix dangerously set inner HTML format * Update package-lock * Update package-lock * Update package-lock * Update @types/dompurify version Co-authored-by: Thomas Roberts <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
sanitizeHTMLreturn value data type and imports to thestore-notices-containerso we don't have two same methods in one repo.Fixes #7230
Screenshots
Testing
In src/Checkout/PaymentsHandler.php, comment or remove the if around the exception:
WooCommerce Visibility
Changelog