This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Use the eslint config at the root of the repo #7149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: |
|
Size Change: 0 B Total Size: 874 kB ℹ️ View Unchanged
|
opr
added
skip-changelog
|
@opr Thank you for catching the unrelated changes! I've updated the changes. |
Thanks @hsingyuc , sorry to be pedantic but there's a line-break deleted in ``assets/js/base/context/providers/store-notices/components/store-notices-container.js` is this on purpose? I think we can just get rid of changes to that file entirely otherwise? |
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
sunyatasattva
added
the
skip-changelog
senadir
pushed a commit
to senadir/woocommerce-blocks
that referenced
this pull request
Nov 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eslint uses both the parent and the current repo's eslint config file. It should ignore parent .eslintrc configuration.
The change uses the eslint config at the root of the repo.
Fixes #7148
Similar PR woocommerce/woocommerce-gateway-stripe#2414
Screenshots
Testing
woopaydocker instancewoocommerce-blocksplugin towoopay/docker/wordpress/wp-content/plugins/woocommerce-blocksnpx eslint --debug .eslintrc.jsto see eslint is not using the config file fromwoopayAutomated Tests
Changes in this PR are covered by Automated Tests.
Do not include in the Testing Notes
WooCommerce Visibility
Performance Impact