This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Make Active filters texts bigger #7087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
status: needs review
skip-changelog
rubikuserbot
requested review from
a team and
danielwrobert
and removed request for
a team
|
@vivialice it would be great if you can take a look at this one and see if the design changes look good. 🙂 |
|
The release ZIP for this PR is accessible via: |
|
Size Change: -31 B (0%) Total Size: 873 kB
ℹ️ View Unchanged
|
Aljullu
removed
the
skip-changelog
There was a problem hiding this comment.
Thanks for working on this!
@vivialice and I spoke briefly about these font sizes earlier this week. IIRC, the idea was to keep the Active Filters smaller and scale everything else down as well, since the filters are secondary UI elements.
I'll leave it to @vivialice to confirm this though. 🙂
|
Oh, I didn't know you had discussed about it, sorry.
Sure, let's wait to see what @vivialice says. It would be good if we can get this into WC Blocks 8.5.0 given that this will end up in WC core. |
That's my fault. We discussed it on a call and I didn't follow up in a public channel. I could have opened an issue around it for better visibility!
Perhaps we can merge this in so we have better consistency for the time being. Then we can plan an effort to address all of the filter text sizes together in an upcoming cycle. I know that means reverting this down the road but I don't see that being too much overhead and it seems a better route in the meantime. Thoughts? |
Works for me. 🙂 |
danielwrobert
approved these changes
Sep 8, 2022
There was a problem hiding this comment.
@Aljullu ok, sounds good! I'll approve this and we can plan for a follow-up on addressing all of the sizing. 🚀
senadir
pushed a commit
to senadir/woocommerce-blocks
that referenced
this pull request
Nov 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a design change suggestion to make Active filters block texts slightly bigger. IMO the active filter texts were abnormally small compared to other filter blocks.
Changes included in this PR:
User Facing Testing
List
Chips
WooCommerce Visibility
Changelog