This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Improve public-facing texts and labels #7045
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We noticed that oftentimes our labels and text tend to be overly technical or unclear. We decided to do a bulk pass to improve the readability to non-technical users.
sunyatasattva
added
type: enhancement
The issue is a request for an enhancement.
focus: accessibility
The issue/PR is related to accessibility.
focus: i18n
The issue/PR is related to internationalization.
type: refactor
The issue/PR is related to refactoring.
labels
Sep 2, 2022
rubikuserbot
requested review from
a team and
albarin
and removed request for
a team
September 2, 2022 15:17
The release ZIP for this PR is accessible via:
|
Size Change: -1.04 kB (0%) Total Size: 872 kB
ℹ️ View Unchanged
|
albarin
reviewed
Sep 5, 2022
@@ -245,7 +245,7 @@ export const AddToCartFormStateContextProvider = ( { | |||
const message = | |||
data.processingResponse?.message || | |||
__( | |||
'Something went wrong. Please contact us to get assistance.', | |||
'Something went wrong. Please contact us for assistance. Please contact us to get assistance.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems duplicated. The same is happening in four more of the Please contact us to get assistance.
messages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow thanks a lot for spotting that @albarin !
albarin
approved these changes
Sep 6, 2022
10 tasks
This was referenced Sep 13, 2022
7 tasks
This was referenced Oct 11, 2022
senadir
pushed a commit
to senadir/woocommerce-blocks
that referenced
this pull request
Nov 12, 2022
We noticed that oftentimes our labels and text tend to be overly technical or unclear. We decided to do a bulk pass to improve the readability to non-technical users.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
focus: accessibility
The issue/PR is related to accessibility.
focus: i18n
The issue/PR is related to internationalization.
type: enhancement
The issue is a request for an enhancement.
type: refactor
The issue/PR is related to refactoring.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that oftentimes our labels and text tend to be overly technical or unclear. We decided to do a bulk pass to improve the readability to non-technical users. I understand that this is a big PR that touches loads of files. Also, we need to find a way to relay to our community of translators that work is required. As such, we also need to decide when it would be best to publish this PR, as it would indeed break many translations. So, for example, I think it might be best to publish it soon after we merge into core, in order to give translators a full release cycle time to fix their translations.
Feel free to use this PR as a hub of discussion for that.
Fixes #6916
WooCommerce Visibility
Changelog