This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix corrupt Classic Template placeholders for specific products. #7033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st matching template details
tjcafferkey
added
type: bug
rubikuserbot
requested review from
a team and
danielwrobert
and removed request for
a team
|
The release ZIP for this PR is accessible via: |
|
Size Change: +93 B (0%) Total Size: 871 kB
ℹ️ View Unchanged
|
… for specific template names
|
@sunyatasattva do you know why these E2E tests would fail with Gutenberg enabled? The Snapshots should not have changed in theory so I'm not convinced they're related to this change but wanted to get your opinion on this to make sure. |
FWIW, I'm seeing the exact same task failing in all of my currently open PRs. |
|
Yea looks like snapshots have changed, possibly Gutenberg related, and we can just update. At a first glance, I don't see anything too worrisome. It looks like there is an extra container div within the group? |
| // Finds the most appropriate template details object for specific template keys such as single-product-hoodie. | ||
| export function getTemplateDetailsBySlug( | ||
| parsedTemplate: string, | ||
| templates: TemplateDetails |
There was a problem hiding this comment.
Do these functions really need to accept a second argument for templates? Is there a circumstance in which we won't use TEMPLATES from constants as this second argument?
There was a problem hiding this comment.
@sunyatasattva I intentionally made this a pure function. I find they're easier to read, reuse and predict. Also much easier to unit test (and debug should those tests fail)
There was a problem hiding this comment.
Alright then! Everything else looks good to me.
sunyatasattva
approved these changes
Sep 6, 2022
senadir
pushed a commit
to senadir/woocommerce-blocks
that referenced
this pull request
Nov 12, 2022
…commerce#7033) * If user has created a template for a specific product, find the closest matching template details * Move Classic Template functions into Utils file and refactor function for specific template names * Classic Template utils refactor and unit tests
6 tasks
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the Gutenberg plugin, you can create specific templates for products, categories and tags via the Appearance > Editor > Add New button. At the moment in the code for the Classic Template Block placeholder we don't accommodate for these specific slugs e.g.
single-product-hoodieso we get an unsupported block notice in the editor as seen below.This PR introduces a change finds the closest matching template. For example
single-product-hoodiewill match the template details forsingle-product(and the same for product categories/tags too).Accessibility
prefers-reduced-motionOther Checks
Screenshots
Testing
Automated Tests
User Facing Testing
Reproduce the original issue:
Test the fix:
WooCommerce Visibility
Performance Impact
Changelog