This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Style the Filter by Price block based on the wrapper width #6943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubikuserbot
requested review from
a team and
danielwrobert
and removed request for
a team
dinhtungdu
added
status: needs review
type: bug
|
The release ZIP for this PR is accessible via: |
|
Size Change: +707 B (0%) Total Size: 868 kB
ℹ️ View Unchanged
|
danielwrobert
approved these changes
Aug 23, 2022
There was a problem hiding this comment.
LGTM! 🚀
Everything tests as described. In addition, I tested different column container widths and everything works as expected across the board.
It would be nice if we could shift the layout with a media query in CSS so we wouldn't have to calculate the wrapper width to set the positioning of the price input fields.
For example, if the input fields are rendered on the same row as the slider bar, they will remain on that row even as the viewport changes in size.
That being said, this is a very nice improvement and if the above route is even a plausible option, it could be considered in a follow-up.
Nice work!
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
@danielwrobert AFAIK, we can't use media query for this because it attaches to the window width. For example, the sidebar can be very narrow on a portrait tablet and we can't detect it using
I noticed this too. We can fix this by listening to the browser |
@dinhtungdu yeah, I see what you're saying. That's a great point!
Yeah, I agree. I think you made the right call here. I approved this PR so my notes weren't meant to be blocking. Great work on this! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6942
This PR calculates the wrapper width on render, then use that width to control the inline layout of the price silder.
300px, theInline input fieldsis forced disabled.Inline input fieldsis enabled or the wrapper width ≤300px, the input field width is always set to60px.These additional conditions make the price slider works as expected with any screen size.
Accessibility
prefers-reduced-motionOther Checks
Screenshots
Testing
Automated Tests
User Facing Testing
300px.300px.WooCommerce Visibility
Performance Impact
N/a
Changelog
N/a