This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
POC: remove the title from filter block #6907
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: |
dinhtungdu
commented
Aug 16, 2022
|
Size Change: +1.37 kB (0%) Total Size: 869 kB
ℹ️ View Unchanged
|
|
Just raising here, my only concern with this approach is that it convolutes the code for this block. So I keep asking myself:
|
I'd say after (almost) all current filter blocks are upgraded. We can't tell when but we can choose a future release to remove the logic where the impact is minimal. After a major WC Blocks version? (just my wild guess).
I'd love to explore more option as well. I don't feel good about adding something meant to be removed in the future too. |
6 tasks
|
Hey I just reviewed the video and tested on my own store. By the way, it looks like this to me (I know this is POC so I understand it isn't final but just in case it's useful)
I think the CTA to upgrade the block makes sense but it's hard to understand what is happening; which block is outdated and what happens after to click the Also, this is relevant for any existing circumstances of filter blocks, correct? So new users shouldn't experience these. |
|
@vivialice it's still a bit of a proof of concept so text and behaviours can be changed, we were just testing the approach from a technical standpoint.
That is correct, new users wont see the prompt. |
dinhtungdu
commented
Aug 24, 2022
7 tasks
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label - otherwise it will automatically be closed after 10 days. |
github-actions
bot
added
the
status: stale
|
Close in favor of #6978 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Releates #6845
This PR is a POC to test the approach of removing the title from the filter block. This PR experiments with the Active Filter block.
Screenshots
Screen.Recording.2022-08-16.at.15.59.30.mov
Testing
Automated Tests
User Facing Testing
WooCommerce Visibility
Performance Impact
Changelog