This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Register patterns under patterns folder and add filters pattern
#6861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: |
|
Size Change: +392 B (0%) Total Size: 872 kB
ℹ️ View Unchanged
|
nerrad
reviewed
Aug 8, 2022
nerrad
reviewed
Aug 8, 2022
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the |
albarin
changed the title
patterns folder and add filters pattern
albarin
added
block-type: filter blocks
rubikuserbot
requested review from
a team and
tjcafferkey
and removed request for
a team
albarin
commented
Aug 9, 2022
tjcafferkey
reviewed
Aug 9, 2022
tjcafferkey
reviewed
Aug 9, 2022
tjcafferkey
reviewed
Aug 9, 2022
tjcafferkey
reviewed
Aug 9, 2022
tjcafferkey
approved these changes
Aug 9, 2022
|
I might be wrong but I think you need to line separate the linked issues to ensure this PR closes them automatically when this is merged. |
|
@tjcafferkey Thanks for the feedback. I pushed some changes, could you have another quick 👀 ? Thanks! |
tjcafferkey
approved these changes
Aug 10, 2022
dinhtungdu
reviewed
Aug 10, 2022
There was a problem hiding this comment.
@albarin Just a minor comment, are you planning to have more classes in src/Patterns?
If not, I think we can move it from src/Patterns/Patterns.php to src/Patterns.php, or even more explicit: src/BlockPatterns.php.
Not for now, I think, I like your |
dinhtungdu
reviewed
Aug 10, 2022
There was a problem hiding this comment.
@albarin Great updates! I left some more comments related to the coding style, please take a look.
tjcafferkey
approved these changes
Aug 11, 2022
There was a problem hiding this comment.
Good feedback @dinhtungdu !
@albarin I've review and retested and it looks good to me!
dinhtungdu
approved these changes
Aug 11, 2022
nerrad
reviewed
Aug 11, 2022
tarunvijwani
added
the
type: enhancement
11 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the new
Patternsclass that is used to register patterns and pattern categories.The patterns are loaded from the
/patternsfolder. It also introduces a new pattern under theWooCommercecategory with all four existing filter blocks (by attribute, price, stock, and active filters).The code to load the patterns from the folder comes from WordPress.
Fixes #6838
Fixes #6839
Fixes #6840
Testing
User Facing Testing
All Productsblock.WooCommerce Filterspatternsfolder of the plugin. The file has to start with a format like:WooCommerce Visibility
Changelog