This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Fix: WooCommerce messages don't appear in block themes with Mini Cart block #6728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubikuserbot
requested review from
a team and
Aljullu
and removed request for
a team
July 21, 2022 11:32
dinhtungdu
added
status: needs review
type: bug
The issue/PR concerns a confirmed bug.
focus: FSE
Work related to prepare WooCommerce for FSE.
block: mini-cart
Issues related to the Mini-Cart block.
labels
Jul 21, 2022
Size Change: 0 B Total Size: 873 kB ℹ️ View Unchanged
|
Aljullu
approved these changes
Jul 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing well and code looks good. 🚢
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
Jul 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
block: mini-cart
Issues related to the Mini-Cart block.
focus: FSE
Work related to prepare WooCommerce for FSE.
type: bug
The issue/PR concerns a confirmed bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6621
When the Mini Cart Block is pre-hydrated, StoreAPI will clear all current notices. This PR ensures add to cart notices are displayed on pages containing Mini Cart block.
Screenshots
Screen.Recording.2022-07-21.at.18.28.39.mov
Testing
Automated Tests
User Facing Testing
WooCommerce Visibility
Changelog