Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Start using block.json and convert to TS the Product by Category block #6680

Merged
merged 4 commits into from
Jul 19, 2022
Merged

Start using block.json and convert to TS the Product by Category block #6680

merged 4 commits into from
Jul 19, 2022

Conversation

albarin
Copy link
Contributor

@albarin albarin commented Jul 13, 2022 •
edited
Loading

Converts the Products by Category block to Typescript and starts using the block.json file.

Testing

User Facing Testing

Test that there are no regressions compared with the previous Products by Category block version.

  1. Create a page and add a Products by Category block.
  2. Save the page and check it renders correctly the default config in the frontend.
  3. Edit the page again and make some changes to the block (hiding some content, changing columns number, ordering, etc.).
  4. Save the page and check it renders properly with the new config.
  • Do not include in the Testing Notes

WooCommerce Visibility

  • WooCommerce Core
  • Feature plugin
  • Experimental

@albarin albarin added type: refactor The issue/PR is related to refactoring. skip-changelog PRs that you don't want to appear in the changelog. focus: blocks Specific work involving or impacting how blocks behave. block: products by category Issues related to the Products by Category block. type: technical debt This issue/PR represents/solves the technical debt of the project. labels Jul 13, 2022
@albarin albarin force-pushed the product-by-cat-to-ts branch from 34853f4 to 5fc52a5 Compare July 13, 2022 14:28
@github-actions
Copy link
Contributor

github-actions bot commented Jul 13, 2022 •
edited
Loading

Size Change: +108 B (0%)

Total Size: 873 kB

Filename Size Change
build/active-filters.js 8 kB -16 B (0%)
build/all-products.js 33.5 kB +1 B (0%)
build/all-reviews.js 7.8 kB -2 B (0%)
build/attribute-filter.js 14.4 kB -5 B (0%)
build/cart.js 44.2 kB -7 B (0%)
build/checkout.js 45.4 kB -5 B (0%)
build/featured-product.js 13.5 kB -9 B (0%)
build/handpicked-products.js 7.37 kB +3 B (0%)
build/legacy-template.js 2.8 kB +1 B (0%)
build/mini-cart-contents.js 22.9 kB -4 B (0%)
build/mini-cart.js 6.62 kB -1 B (0%)
build/price-filter.js 9.04 kB -5 B (0%)
build/product-add-to-cart.js 6.63 kB -4 B (0%)
build/product-best-sellers.js 7.43 kB +3 B (0%)
build/product-button.js 1.09 kB -3 B (0%)
build/product-categories.js 2.78 kB -2 B (0%)
build/product-category-list.js 501 B +1 B (0%)
build/product-category.js 8.69 kB +155 B (+2%)
build/product-new.js 7.71 kB +3 B (0%)
build/product-on-sale.js 8.03 kB +2 B (0%)
build/product-price.js 1.5 kB +1 B (0%)
build/product-sale-badge.js 680 B +1 B (0%)
build/product-search.js 2.18 kB -3 B (0%)
build/product-stock-indicator.js 619 B -2 B (0%)
build/product-tag-list.js 496 B +1 B (0%)
build/product-title.js 909 B +1 B (0%)
build/products-by-attribute.js 8.63 kB -1 B (0%)
build/reviews-by-category.js 11.2 kB -2 B (0%)
build/reviews-by-product.js 12.3 kB -2 B (0%)
build/single-product.js 10.1 kB +8 B (0%)
build/stock-filter.js 7.31 kB -1 B (0%)
build/wc-blocks-vendors.js 58.8 kB +2 B (0%)
build/wc-blocks.js 2.63 kB -1 B (0%)
ℹ️ View Unchanged
Filename Size
build/active-filters-frontend.js 7.34 kB
build/all-products-frontend.js 18.1 kB
build/attribute-filter-frontend.js 25.1 kB
build/blocks-checkout.js 17.4 kB
build/cart-blocks/cart-accepted-payment-methods-frontend.js 1.16 kB
build/cart-blocks/cart-express-payment-frontend.js 5.07 kB
build/cart-blocks/cart-items-frontend.js 299 B
build/cart-blocks/cart-line-items--mini-cart-contents-block/products-table-frontend.js 5.27 kB
build/cart-blocks/cart-line-items-frontend.js 430 B
build/cart-blocks/cart-order-summary-frontend.js 1.11 kB
build/cart-blocks/cart-totals-frontend.js 322 B
build/cart-blocks/empty-cart-frontend.js 346 B
build/cart-blocks/filled-cart-frontend.js 782 B
build/cart-blocks/order-summary-coupon-form-frontend.js 2.62 kB
build/cart-blocks/order-summary-discount-frontend.js 2.12 kB
build/cart-blocks/order-summary-fee-frontend.js 273 B
build/cart-blocks/order-summary-heading-frontend.js 455 B
build/cart-blocks/order-summary-shipping--checkout-blocks/order-summary-shipping-frontend.js 6.34 kB
build/cart-blocks/order-summary-shipping-frontend.js 428 B
build/cart-blocks/order-summary-subtotal-frontend.js 274 B
build/cart-blocks/order-summary-taxes-frontend.js 434 B
build/cart-blocks/proceed-to-checkout-frontend.js 1.16 kB
build/cart-frontend.js 45.6 kB
build/checkout-blocks/actions-frontend.js 1.41 kB
build/checkout-blocks/billing-address--checkout-blocks/shipping-address-frontend.js 4.12 kB
build/checkout-blocks/billing-address-frontend.js 890 B
build/checkout-blocks/contact-information-frontend.js 2.83 kB
build/checkout-blocks/express-payment-frontend.js 5.36 kB
build/checkout-blocks/fields-frontend.js 345 B
build/checkout-blocks/order-note-frontend.js 1.08 kB
build/checkout-blocks/order-summary-cart-items-frontend.js 3.67 kB
build/checkout-blocks/order-summary-coupon-form-frontend.js 2.78 kB
build/checkout-blocks/order-summary-discount-frontend.js 2.25 kB
build/checkout-blocks/order-summary-fee-frontend.js 276 B
build/checkout-blocks/order-summary-frontend.js 1.11 kB
build/checkout-blocks/order-summary-shipping-frontend.js 604 B
build/checkout-blocks/order-summary-subtotal-frontend.js 274 B
build/checkout-blocks/order-summary-taxes-frontend.js 433 B
build/checkout-blocks/payment-frontend.js 7.67 kB
build/checkout-blocks/shipping-address-frontend.js 991 B
build/checkout-blocks/shipping-methods-frontend.js 4.72 kB
build/checkout-blocks/terms-frontend.js 1.22 kB
build/checkout-blocks/totals-frontend.js 326 B
build/checkout-frontend.js 47.9 kB
build/featured-category.js 13.2 kB
build/mini-cart-component-frontend.js 16.6 kB
build/mini-cart-contents-block/empty-cart-frontend.js 364 B
build/mini-cart-contents-block/filled-cart-frontend.js 229 B
build/mini-cart-contents-block/footer--mini-cart-contents-block/products-table-frontend.js 4.68 kB
build/mini-cart-contents-block/footer-frontend.js 5.75 kB
build/mini-cart-contents-block/items-frontend.js 225 B
build/mini-cart-contents-block/products-table-frontend.js 289 B
build/mini-cart-contents-block/shopping-button-frontend.js 288 B
build/mini-cart-contents-block/title-frontend.js 367 B
build/mini-cart-frontend.js 1.72 kB
build/price-filter-frontend.js 13.1 kB
build/price-format.js 1.19 kB
build/product-add-to-cart--product-button--product-category-list--product-image--product-price--product-r--a0326d00.js 223 B
build/product-add-to-cart--product-button--product-image--product-title.js 2.65 kB
build/product-add-to-cart--product-button.js 564 B
build/product-add-to-cart-frontend.js 6.96 kB
build/product-button--product-category-list--product-image--product-price--product-rating--product-sale-b--e17c7c01.js 500 B
build/product-button-frontend.js 1.85 kB
build/product-category-list-frontend.js 921 B
build/product-image-frontend.js 1.84 kB
build/product-image.js 1.08 kB
build/product-price-frontend.js 1.94 kB
build/product-rating-frontend.js 1.15 kB
build/product-rating.js 729 B
build/product-sale-badge-frontend.js 1.09 kB
build/product-sku-frontend.js 380 B
build/product-sku.js 381 B
build/product-stock-indicator-frontend.js 1.03 kB
build/product-summary-frontend.js 1.33 kB
build/product-summary.js 916 B
build/product-tag-list-frontend.js 915 B
build/product-tag.js 8.08 kB
build/product-title-frontend.js 1.29 kB
build/product-top-rated.js 7.95 kB
build/reviews-frontend.js 7.02 kB
build/single-product-frontend.js 21.4 kB
build/stock-filter-frontend.js 7.39 kB
build/vendors--cart-blocks/cart-line-items--cart-blocks/cart-order-summary--cart-blocks/order-summary-shi--c02aad66-frontend.js 5.26 kB
build/vendors--cart-blocks/cart-line-items--checkout-blocks/order-summary-cart-items--mini-cart-contents---233ab542-frontend.js 3.14 kB
build/vendors--cart-blocks/order-summary-shipping--checkout-blocks/billing-address--checkout-blocks/order--5b8feb0b-frontend.js 4.74 kB
build/vendors--cart-blocks/order-summary-shipping--checkout-blocks/billing-address--checkout-blocks/order--decc3dc6-frontend.js 19.1 kB
build/vendors--mini-cart-contents-block/footer-frontend.js 6.86 kB
build/vendors--product-add-to-cart-frontend.js 7.53 kB
build/wc-blocks-data.js 9.87 kB
build/wc-blocks-editor-style-rtl.css 5.04 kB
build/wc-blocks-editor-style.css 5.04 kB
build/wc-blocks-google-analytics.js 1.56 kB
build/wc-blocks-middleware.js 930 B
build/wc-blocks-registry.js 2.7 kB
build/wc-blocks-shared-context.js 1.52 kB
build/wc-blocks-shared-hocs.js 1.14 kB
build/wc-blocks-style-rtl.css 22.1 kB
build/wc-blocks-style.css 22 kB
build/wc-blocks-vendors-style-rtl.css 1.26 kB
build/wc-blocks-vendors-style.css 1.26 kB
build/wc-payment-method-bacs.js 816 B
build/wc-payment-method-cheque.js 811 B
build/wc-payment-method-cod.js 909 B
build/wc-payment-method-paypal.js 837 B
build/wc-settings.js 2.6 kB

compressed-size-action

@albarin albarin marked this pull request as ready for review July 13, 2022 14:45
@rubikuserbot rubikuserbot requested review from a team and gigitux and removed request for a team July 13, 2022 14:45
gigitux
gigitux suggested changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@gigitux gigitux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Everything works!
I added some comments with the aim of not introducing any TS errors in the codebase. Let's see if it is possible 💪

assets/js/blocks/product-category/edit-mode.tsx Outdated Show resolved Hide resolved
assets/js/blocks/product-category/edit-mode.tsx Outdated Show resolved Hide resolved
assets/js/blocks/product-category/edit-mode.tsx Show resolved Hide resolved
assets/js/blocks/product-category/edit.tsx Outdated Show resolved Hide resolved
assets/js/blocks/product-category/inspector-controls.tsx Show resolved Hide resolved
assets/js/blocks/product-category/inspector-controls.tsx Show resolved Hide resolved
@gigitux gigitux mentioned this pull request Jul 15, 2022
Merged
3 tasks
@albarin albarin requested a review from gigitux July 19, 2022 12:43
@albarin
Copy link
Contributor Author

albarin commented Jul 19, 2022

Great work! Everything works! I added some comments with the aim of not introducing any TS errors in the codebase. Let's see if it is possible 💪

I think I have addressed all your comments, could you have another quick look? 🙏 Thanks!

gigitux
gigitux approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@gigitux gigitux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing all the comments! LGTM! 🚢

@github-actions github-actions bot added this to the 8.2.0 milestone Jul 19, 2022
@albarin albarin merged commit 9371278 into trunk Jul 19, 2022
@albarin albarin deleted the product-by-cat-to-ts branch July 19, 2022 13:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gigitux gigitux gigitux approved these changes

Assignees
No one assigned
Labels
block: products by category Issues related to the Products by Category block. focus: blocks Specific work involving or impacting how blocks behave. skip-changelog PRs that you don't want to appear in the changelog. type: refactor The issue/PR is related to refactoring. type: technical debt This issue/PR represents/solves the technical debt of the project.
Projects
None yet
Milestone
8.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@albarin @gigitux