This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Mini Cart: Fix loading deps when WordPress is installed in a subdir #6673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix loading deps when WordPress is installed in a subdir
gigitux
added
type: bug
rubikuserbot
requested review from
a team and
Aljullu
and removed request for
a team
|
I'm going to add @dinhtungdu as a reviewer because I'm not sure about my approach and this issue is a little bit tricky: I prefer that more eyes will review this! |
gigitux
changed the title
|
Size Change: 0 B Total Size: 876 kB ℹ️ View Unchanged
|
dinhtungdu
reviewed
Jul 12, 2022
There was a problem hiding this comment.
@gigitux This is working as expected on my end. I think we can use this approach just fine. If I have to change anything in this PR, I would:
- Use the site URL directly without parsing the path.
- Use a simpler way to check whether script
srcis an URL. Thewp_http_validate_url()seems to be an overkill for this task to me.
You can also look at how Core is dealing with the script src here (and here).
Thanks for the review and links! I updated the PR 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the loading of Mini Cart deps when WordPress is installed in a subdirectory. Fixes #6500.
Without these changes, the Mini Cart deps are ALWAYS loading from the root of the website, but this is wrong because WordPress could be installed in a subdirectory.
How to reproduce the error
For reproducing the error, it is necessary installing WordPress in a subdirectory. The quickest and easiest way that I found it is:
wordpress(as the guide suggests).wrong request (missing
/wordpress)with the changes of this PR, the browser fetches deps from the right URLs
Testing
User Facing Testing
Check out this branch
WooCommerce Visibility