This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Add cross sells products to preview cart #6570
Closed
nielslange
wants to merge
2
commits into
trunk
from
add/6556-add-cross-sells-products-to-previewCart
Closed
Add cross sells products to preview cart #6570
nielslange
wants to merge
2
commits into
trunk
from
add/6556-add-cross-sells-products-to-previewCart
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielslange
added
type: new block
Applied to work that introduces a new block (typically used on an epic issue).
skip-changelog
PRs that you don't want to appear in the changelog.
block: cart
Issues related to the cart block.
labels
Jun 14, 2022
Size Change: +1.19 kB (0%) Total Size: 866 kB
ℹ️ View Unchanged
|
Hey @nielslange do you want to pull #6635 into this branch, and start integrating the new cart response? There are some issues @senadir raised, but client-facing API response won't change. Also, #6635 should be merged first so updating this with trunk will clean up that extra temporary code. |
Closing this issue, as #6645 builds on top of this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
block: cart
Issues related to the cart block.
skip-changelog
PRs that you don't want to appear in the changelog.
type: new block
Applied to work that introduces a new block (typically used on an epic issue).
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6556
Currently, the Cross-Sells products are only available in the shortcode-based Cart, but not in the Cart block. To make the Cross-Sells products available in the editor when viewing the Cart block, we need to add demo products to export const previewCart. This PR is taking care of this.
Accessibility
prefers-reduced-motion
Other Checks
Testing
User Facing Testing
WooCommerce Visibility
Performance Impact
n/a
Changelog
n/a