Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Fix product preview bugs #65

Merged
merged 8 commits into from
Mar 12, 2018
Merged

Fix product preview bugs #65

merged 8 commits into from
Mar 12, 2018

Conversation

claudiulodro
Copy link
Contributor

@claudiulodro claudiulodro commented Mar 9, 2018

#57 should be merged before this is reviewed, as this PR builds off the changes from #57.

To test:

  • Make a new product block
  • Observe the grid/list toggle is not visible until you've selected a scope.
  • In preview mode, verify everything looks good for 1-6 rows/columns.

@claudiulodro claudiulodro added this to the 1.0 milestone Mar 9, 2018
Copy link
Member

@jameskoster jameskoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should hide the grid/list toggle entirely in edit mode; https://cloudup.com/cRuds3n6ZJ9

Everything else looks good!

@claudiulodro
Copy link
Contributor Author

Made the requested change. Going to merge this.

@claudiulodro claudiulodro merged commit db9535a into master Mar 12, 2018
@claudiulodro claudiulodro deleted the fix/bugs branch March 12, 2018 17:21
luisherranz pushed a commit to luisherranz/woocommerce-blocks that referenced this pull request Sep 20, 2022
…ctive-blocks

Unmount react component when WpBlock is disconnected
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants