This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix an endless loop when using product grid blocks inside product descriptions #6471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
status: needs review
type: bug
rubikuserbot
requested review from
a team and
albarin
and removed request for
a team
7 tasks
|
Size Change: +3.17 kB (0%) Total Size: 865 kB
ℹ️ View Unchanged
|
albarin
approved these changes
May 30, 2022
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
|
Thanks for the review, @albarin! I'm holding off on merging this PR based on this comment, in case we need to make any additional changes here. |
|
Had a quick look at this and thinking - if we remove the post id from the query, should we re-add the post from I think the way it works with the change is it would exclude such post and it would be missing from results even if it was requested explicitly with |
You're right, @tomasztunik!
That makes sense to me, did you investigate how that could be done? While I believe it's a great idea, I think we should keep in mind we are fixing a bug for an unsupported edge case, so I would be wary to spend too much time on this if the solution is not straight-forward. |
|
Didn't really look into the implementation - I agree that this fix is still better than the app crashing. We might want to open up a follow-up issue to track the side-effect of this fix where we could continue the conversation if we should seek to cover this edge case. |
|
The e2e failure with the wrong number of products returned for the filter by price is unrelated? seems odd failure for a flaky test? |
|
Hmmm, that's weird. Tests are passing for me locally, and I see the same test is failing in another unrelated PR (#6505), so I would say it's unrelated. Also, I don't think filter blocks make use of |
|
Hey @Aljullu - I was LMAFK last week - I'll make sure to reply to your comment today/tomorrow and possibly add one more commit to bring the "parent". |
|
@Aljullu all good - no need for a revision check 👉 #6454 (comment) |
14 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works-around #6416 in the frontend.
Inspired by #6454.
Testing
Automated Tests
User Facing Testing
functions.phpof your theme):WooCommerce Visibility
Changelog