Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Revert "Add requireExactMatch prop to ComboBox to prevent wrong country/state values being sent to the server" #6447

Merged
merged 1 commit into from
May 24, 2022
Merged

Revert "Add requireExactMatch prop to ComboBox to prevent wrong country/state values being sent to the server" #6447

merged 1 commit into from
May 24, 2022

Conversation

opr
Copy link
Contributor

@opr opr commented May 24, 2022

Reverts #6426 due to the changes introducing a poor UX

Testing

To test, please ensure you can enter your address and change country in the Checkout Block.

@opr
Revert "Add requireExactMatch prop to ComboBox to prevent wrong c…
1db7165 
…ountry/state values being sent to the server (#6426)"

This reverts commit 5a2a979.
@opr opr added status: needs review status: blocker Used on issues or pulls that block work from being released. focus: components Work that introduces new or updates existing components. block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. labels May 24, 2022
@opr opr added this to the 7.7.0 milestone May 24, 2022
@opr opr self-assigned this May 24, 2022
@rubikuserbot rubikuserbot requested review from a team and wavvves and removed request for a team May 24, 2022 07:57
@github-actions
Copy link
Contributor

Script Dependencies Report

The compare-assets action has detected some changed script dependencies between this branch and trunk. Please review and confirm the following are correct before merging.

Script Handle Added Removed
reviews-frontend.js react, wc-settings, wp-a11y, wp-api-fetch, wp-compose, wp-element, wp-html-entities, wp-i18n, wp-is-shallow-equal, wp-polyfill ⚠️
all-products-frontend.js lodash, react, wc-blocks-data-store, wc-blocks-registry, wc-blocks-shared-context, wc-blocks-shared-hocs, wc-price-format, wc-settings, wp-a11y, wp-api-fetch, wp-autop, wp-block-editor, wp-blocks, wp-compose, wp-data, wp-deprecated, wp-dom, wp-element, wp-hooks, wp-html-entities, wp-i18n, wp-is-shallow-equal, wp-polyfill, wp-primitives, wp-url, wp-warning, wp-wordcount ⚠️
price-filter-frontend.js lodash, react, wc-blocks-data-store, wc-price-format, wc-settings, wp-data, wp-element, wp-i18n, wp-is-shallow-equal, wp-polyfill, wp-url ⚠️
attribute-filter-frontend.js lodash, react, wc-blocks-data-store, wc-settings, wp-a11y, wp-block-editor, wp-blocks, wp-components, wp-data, wp-element, wp-html-entities, wp-i18n, wp-is-shallow-equal, wp-polyfill, wp-primitives, wp-url ⚠️
stock-filter-frontend.js lodash, react, wc-blocks-data-store, wc-settings, wp-a11y, wp-data, wp-element, wp-html-entities, wp-i18n, wp-is-shallow-equal, wp-polyfill, wp-url ⚠️
active-filters-frontend.js lodash, react, wc-blocks-data-store, wc-price-format, wc-settings, wp-data, wp-element, wp-html-entities, wp-i18n, wp-is-shallow-equal, wp-polyfill, wp-primitives, wp-url ⚠️
cart-frontend.js lodash, react, wc-blocks-checkout, wc-blocks-data-store, wc-blocks-registry, wc-blocks-shared-hocs, wc-price-format, wc-settings, wp-a11y, wp-api-fetch, wp-autop, wp-compose, wp-data, wp-deprecated, wp-dom, wp-element, wp-hooks, wp-html-entities, wp-i18n, wp-is-shallow-equal, wp-keycodes, wp-plugins, wp-polyfill, wp-primitives, wp-url, wp-warning, wp-wordcount ⚠️
checkout-frontend.js lodash, react, wc-blocks-checkout, wc-blocks-data-store, wc-blocks-registry, wc-blocks-shared-hocs, wc-price-format, wc-settings, wp-a11y, wp-api-fetch, wp-autop, wp-compose, wp-data, wp-deprecated, wp-dom, wp-element, wp-hooks, wp-html-entities, wp-i18n, wp-is-shallow-equal, wp-keycodes, wp-plugins, wp-polyfill, wp-primitives, wp-url, wp-warning, wp-wordcount ⚠️
mini-cart-frontend.js wc-settings, wp-polyfill ⚠️
single-product-frontend.js lodash, react, wc-blocks-checkout, wc-blocks-data-store, wc-blocks-registry, wc-blocks-shared-context, wc-blocks-shared-hocs, wc-price-format, wc-settings, wp-a11y, wp-api-fetch, wp-autop, wp-block-editor, wp-blocks, wp-compose, wp-data, wp-deprecated, wp-dom, wp-element, wp-hooks, wp-html-entities, wp-i18n, wp-is-shallow-equal, wp-polyfill, wp-primitives, wp-url, wp-warning, wp-wordcount ⚠️
mini-cart-component-frontend.js lodash, react, wc-blocks-checkout, wc-blocks-data-store, wc-blocks-registry, wc-price-format, wc-settings, wp-a11y, wp-autop, wp-components, wp-compose, wp-data, wp-deprecated, wp-dom, wp-element, wp-hooks, wp-html-entities, wp-i18n, wp-is-shallow-equal, wp-keycodes, wp-polyfill, wp-primitives, wp-url, wp-warning, wp-wordcount ⚠️

This comment was automatically generated by the ./github/compare-assets action.

@github-actions
Copy link
Contributor

Size Change: -207 B (0%)

Total Size: 924 kB

Filename Size Change
build/cart-blocks/order-summary-shipping-frontend.js 15.3 kB -29 B (0%)
build/cart-frontend.js 45.5 kB -2 B (0%)
build/cart.js 44.3 kB -50 B (0%)
build/checkout-blocks/billing-address-frontend.js 10.7 kB -29 B (0%)
build/checkout-blocks/order-summary-shipping-frontend.js 15.4 kB -29 B (0%)
build/checkout-blocks/shipping-address-frontend.js 10.8 kB -29 B (0%)
build/checkout-frontend.js 47.7 kB -4 B (0%)
build/checkout.js 45.6 kB -35 B (0%)
ℹ️ View Unchanged
Filename Size
build/active-filters-frontend.js 6.59 kB
build/active-filters.js 7.43 kB
build/all-products-frontend.js 18.2 kB
build/all-products.js 33.3 kB
build/all-reviews.js 7.79 kB
build/attribute-filter-frontend.js 17.7 kB
build/attribute-filter.js 13.8 kB
build/blocks-checkout.js 17.4 kB
build/cart-blocks/cart-accepted-payment-methods-frontend.js 1.16 kB
build/cart-blocks/cart-express-payment-frontend.js 5.25 kB
build/cart-blocks/cart-items-frontend.js 299 B
build/cart-blocks/cart-line-items-frontend.js 5.51 kB
build/cart-blocks/cart-order-summary-frontend.js 1.1 kB
build/cart-blocks/cart-totals-frontend.js 321 B
build/cart-blocks/empty-cart-frontend.js 345 B
build/cart-blocks/filled-cart-frontend.js 783 B
build/cart-blocks/order-summary-coupon-form-frontend.js 2.81 kB
build/cart-blocks/order-summary-discount-frontend.js 2.31 kB
build/cart-blocks/order-summary-fee-frontend.js 273 B
build/cart-blocks/order-summary-heading-frontend.js 455 B
build/cart-blocks/order-summary-subtotal-frontend.js 273 B
build/cart-blocks/order-summary-taxes-frontend.js 432 B
build/cart-blocks/proceed-to-checkout-frontend.js 1.15 kB
build/checkout-blocks/actions-frontend.js 1.41 kB
build/checkout-blocks/contact-information-frontend.js 2.84 kB
build/checkout-blocks/express-payment-frontend.js 5.54 kB
build/checkout-blocks/fields-frontend.js 344 B
build/checkout-blocks/order-note-frontend.js 1.07 kB
build/checkout-blocks/order-summary-cart-items-frontend.js 3.66 kB
build/checkout-blocks/order-summary-coupon-form-frontend.js 2.96 kB
build/checkout-blocks/order-summary-discount-frontend.js 2.43 kB
build/checkout-blocks/order-summary-fee-frontend.js 275 B
build/checkout-blocks/order-summary-frontend.js 1.11 kB
build/checkout-blocks/order-summary-subtotal-frontend.js 273 B
build/checkout-blocks/order-summary-taxes-frontend.js 432 B
build/checkout-blocks/payment-frontend.js 7.59 kB
build/checkout-blocks/shipping-methods-frontend.js 4.46 kB
build/checkout-blocks/terms-frontend.js 1.22 kB
build/checkout-blocks/totals-frontend.js 326 B
build/featured-category.js 13.1 kB
build/featured-product.js 13.4 kB
build/handpicked-products.js 7.39 kB
build/legacy-template.js 2.2 kB
build/mini-cart-component-frontend.js 16.5 kB
build/mini-cart-contents-block/empty-cart-frontend.js 365 B
build/mini-cart-contents-block/filled-cart-frontend.js 229 B
build/mini-cart-contents-block/footer-frontend.js 10.3 kB
build/mini-cart-contents-block/items-frontend.js 226 B
build/mini-cart-contents-block/products-table-frontend.js 9.69 kB
build/mini-cart-contents-block/shopping-button-frontend.js 288 B
build/mini-cart-contents-block/title-frontend.js 366 B
build/mini-cart-contents.js 22.7 kB
build/mini-cart-frontend.js 1.72 kB
build/mini-cart.js 6.1 kB
build/price-filter-frontend.js 12.5 kB
build/price-filter.js 8.74 kB
build/price-format.js 1.19 kB
build/product-add-to-cart--product-button--product-image--product-title.js 2.71 kB
build/product-add-to-cart-frontend.js 12.4 kB
build/product-add-to-cart.js 6.89 kB
build/product-best-sellers.js 7.47 kB
build/product-button-frontend.js 1.84 kB
build/product-button.js 1.77 kB
build/product-categories.js 2.78 kB
build/product-category-list-frontend.js 924 B
build/product-category-list.js 945 B
build/product-category.js 8.59 kB
build/product-image-frontend.js 1.84 kB
build/product-image.js 1.8 kB
build/product-new.js 7.76 kB
build/product-on-sale.js 8.08 kB
build/product-price-frontend.js 1.94 kB
build/product-price.js 1.93 kB
build/product-rating-frontend.js 1.15 kB
build/product-rating.js 1.17 kB
build/product-sale-badge-frontend.js 1.09 kB
build/product-sale-badge.js 1.11 kB
build/product-search.js 2.18 kB
build/product-sku-frontend.js 379 B
build/product-sku.js 382 B
build/product-stock-indicator-frontend.js 1.03 kB
build/product-stock-indicator.js 1.06 kB
build/product-summary-frontend.js 1.33 kB
build/product-summary.js 1.35 kB
build/product-tag-list-frontend.js 918 B
build/product-tag-list.js 940 B
build/product-tag.js 8.12 kB
build/product-title-frontend.js 1.29 kB
build/product-title.js 1.25 kB
build/product-top-rated.js 8 kB
build/products-by-attribute.js 8.69 kB
build/reviews-by-category.js 11.3 kB
build/reviews-by-product.js 12.3 kB
build/reviews-frontend.js 7.02 kB
build/single-product-frontend.js 21.5 kB
build/single-product.js 9.93 kB
build/stock-filter-frontend.js 6.87 kB
build/stock-filter.js 6.95 kB
build/vendor/dinero.js-frontend.js 3.14 kB
build/vendor/emotion-element-cbed451f.browser.esm.js-frontend.js 717 B
build/vendor/react-number-format.es.js-frontend.js 5.26 kB
build/vendor/stylis.mjs-frontend.js 2.89 kB
build/vendor/tinycolor.js-frontend.js 5.12 kB
build/wc-blocks-data.js 9.87 kB
build/wc-blocks-editor-style-rtl.css 5.04 kB
build/wc-blocks-editor-style.css 5.04 kB
build/wc-blocks-google-analytics.js 1.56 kB
build/wc-blocks-middleware.js 930 B
build/wc-blocks-registry.js 2.7 kB
build/wc-blocks-shared-context.js 1.52 kB
build/wc-blocks-shared-hocs.js 1.14 kB
build/wc-blocks-style-rtl.css 22.1 kB
build/wc-blocks-style.css 22.1 kB
build/wc-blocks-vendors-style-rtl.css 1.28 kB
build/wc-blocks-vendors-style.css 1.28 kB
build/wc-blocks-vendors.js 71.5 kB
build/wc-blocks.js 2.63 kB
build/wc-payment-method-bacs.js 816 B
build/wc-payment-method-cheque.js 811 B
build/wc-payment-method-cod.js 909 B
build/wc-payment-method-paypal.js 837 B
build/wc-settings.js 2.61 kB
build/wp/wp-components.js-frontend.js 22.3 kB

compressed-size-action

@danieldudzic danieldudzic merged commit 40d27b7 into trunk May 24, 2022
@danieldudzic danieldudzic deleted the revert-6426-fix/state-country-wrong-values branch May 24, 2022 08:49
@danieldudzic danieldudzic added the skip-changelog PRs that you don't want to appear in the changelog. label May 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ralucaStan ralucaStan ralucaStan approved these changes

@wavvves wavvves Awaiting requested review from wavvves wavvves was automatically assigned from woocommerce/rubik

Assignees

@opr opr

Labels
block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. focus: components Work that introduces new or updates existing components. skip-changelog PRs that you don't want to appear in the changelog. status: blocker Used on issues or pulls that block work from being released.
Projects
None yet
Milestone
7.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@opr @ralucaStan @danieldudzic