This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Add Fixed/Repeated background
to the Featured Category
block
#6440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubikuserbot
requested review from
a team and
dinhtungdu
and removed request for
a team
May 23, 2022 09:31
albarin
added
type: enhancement
The issue is a request for an enhancement.
block: featured category
Issues related to the Featured Category block,
focus: components
Work that introduces new or updates existing components.
labels
May 23, 2022
Size Change: +24 B (0%) Total Size: 924 kB
ℹ️ View Unchanged
|
sunyatasattva
approved these changes
May 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me and it works fine as far as I can see! :)
Script Dependencies ReportThe
This comment was automatically generated by the |
3 tasks
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
block: featured category
Issues related to the Featured Category block,
focus: components
Work that introduces new or updates existing components.
type: enhancement
The issue is a request for an enhancement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
Fixed image
andRepeated image
media controls for theFeatured Category
block and fixes the gradient overlay.It also includes a small refactor of the
Featured Product
block to unify how things are done in theFeatured Category
as a first step for bigger refactor.Fixes part of #6236
Testing
How to test the changes in this Pull Request:
Featured Category
block.Media Settings
and toggleFixed image
andRepeated image
and save.Fixed image
,Repeated image
and any other configuration.Featured Product
block.Changelog