This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Cache node_modules between workflows #6404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubikuserbot
requested review from
a team and
tarhi-saad
and removed request for
a team
alexflorisca
added
tools
|
Size Change: +48.1 kB (+5%) 🔍 Total Size: 924 kB
ℹ️ View Unchanged
|
Script Dependencies ReportThe
This comment was automatically generated by the |
Script Dependencies ReportThe
This comment was automatically generated by the |
tomasztunik
reviewed
May 12, 2022
tarhi-saad
suggested changes
May 24, 2022
There was a problem hiding this comment.
Hi @alexflorisca! Thank you for this great PR! We indeed needed faster CI checks! 🙌
I've left some change requests below! 👍
|
Thanks for the review @tarhi-saad! I've addressed your comments above 👍 |
tarhi-saad
approved these changes
May 24, 2022
There was a problem hiding this comment.
Hi @alexflorisca! Thank you for answering all my questions! This LGTM, so let's 🚢 it!
alexflorisca
added
the
skip-changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR caches
node_modulesin between github action workflows to speed things up. The cache is based on thepackage-lock.jsonfile and the os that the action is running on. So we will be invalidating the cache everytime a dependency changes. This is a significant time saver, as wenpm ciin quite a few places independently which is unnecessary.Note that we are already using
actions/setup-nodewith thecache: npmoption. This caches the~/.npmdirectory which contains package data to save downloading from servers for everynpm install. However node_modules are not cached as part of theactions/setup-nodeaction.Also, for the Unit Tests workflow, we are running the build step only in the Setup job and saving as artefacts for the other two jobs
Fixes #5689
To test: