This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Fix: Mini Cart block is not available from the Edit template screen #6351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubikuserbot
requested review from
a team and
tjcafferkey
and removed request for
a team
April 30, 2022 09:13
dinhtungdu
added
status: needs review
type: bug
The issue/PR concerns a confirmed bug.
block: mini-cart
Issues related to the Mini-Cart block.
labels
Apr 30, 2022
Size Change: 0 B Total Size: 872 kB ℹ️ View Unchanged
|
tjcafferkey
approved these changes
May 4, 2022
Script Dependencies ReportThe
This comment was automatically generated by the |
Script Dependencies ReportThe
This comment was automatically generated by the |
Closed
Failed E2E test is unrelated. Merged with failed workflow. |
4 tasks
This was referenced Jul 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
block: mini-cart
Issues related to the Mini-Cart block.
type: bug
The issue/PR concerns a confirmed bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6342
This PR reverts the change in #5653 to register the Mini Cart and Mini Cart Contents blocks for all screens. This allows the Mini Cart block to be available in the Template Editor which is loaded inside the Block Editor.
I decided to register both Mini Cart and Mini Cart Contents blocks for all screens to make the code simpler. The Mini Cart Contents block isn't visible in the inserter so the change in this PR won't affect the end-user experience.
Accessibility
prefers-reduced-motion
Other Checks
Screenshots
Testing
Automated Tests
User Facing Testing
4. Notice the Mini Cart block works as expected.
Changelog