Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Ensure Filter Products by Attribute block reloads the page when interacting with PHP templates #6332

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Ensure Filter Products by Attribute block reloads the page when interacting with PHP templates #6332

merged 1 commit into from
Apr 28, 2022

Conversation

Aljullu
Copy link
Contributor

@Aljullu Aljullu commented Apr 27, 2022 •
edited by tjcafferkey
Loading

Fixes #6331.

Heads-up that there is a follow-up PR which does some code clean-up: #6333.

Screenshots

Kooha-04-27-2022-05-22-55.mp4

Manual Testing

  1. With a block theme, go to Appearance > Site Editor.
  2. Go to Templates and edit the Product Catalog template.
  3. Above the WooCommerce Classic Template block, add the Filter Products by Attribute block (making sure you only have one Filter Products by Attribute block) and set its Filter button attribute to true.
  4. In the frontend, filter by attribute.
  5. Verify the page reloads and the filter is applied.

Changelog

Fix Filter Products by Attribute block not working on PHP templates when Filter button was enabled.

@Aljullu Aljullu added type: bug The issue/PR concerns a confirmed bug. block: filter by attribute Issues related to the Filter by Attribute block. labels Apr 27, 2022
@Aljullu Aljullu self-assigned this Apr 27, 2022
@rubikuserbot rubikuserbot requested review from a team and tjcafferkey and removed request for a team April 27, 2022 03:25
@github-actions
Copy link
Contributor

Size Change: -41 B (0%)

Total Size: 869 kB

Filename Size Change
build/active-filters-frontend.js 6.55 kB -19 B (0%)
build/active-filters.js 7.25 kB +2 B (0%)
build/all-products-frontend.js 18.1 kB +4 B (0%)
build/attribute-filter-frontend.js 17.7 kB -8 B (0%)
build/attribute-filter.js 13.5 kB -3 B (0%)
build/cart-blocks/cart-line-items--mini-cart-contents-block/products-table-frontend.js 5.27 kB -1 B (0%)
build/cart-blocks/cart-line-items-frontend.js 430 B -3 B (-1%)
build/cart-frontend.js 45.5 kB +6 B (0%)
build/checkout-frontend.js 47.7 kB -4 B (0%)
build/checkout.js 45.6 kB -1 B (0%)
build/mini-cart-component-frontend.js 16.6 kB -5 B (0%)
build/mini-cart-contents.js 22.7 kB +2 B (0%)
build/price-filter-frontend.js 12.4 kB -11 B (0%)
build/price-filter.js 8.49 kB -1 B (0%)
build/reviews-by-product.js 12.2 kB +1 B (0%)
build/single-product-frontend.js 21.5 kB +4 B (0%)
build/stock-filter-frontend.js 6.85 kB -5 B (0%)
build/wc-blocks-vendors.js 71.4 kB +1 B (0%)
ℹ️ View Unchanged
Filename Size
build/all-products.js 33.4 kB
build/all-reviews.js 7.78 kB
build/blocks-checkout.js 17.4 kB
build/cart-blocks/cart-accepted-payment-methods-frontend.js 1.16 kB
build/cart-blocks/cart-express-payment-frontend.js 5.24 kB
build/cart-blocks/cart-items-frontend.js 299 B
build/cart-blocks/cart-order-summary-frontend.js 1.1 kB
build/cart-blocks/cart-totals-frontend.js 322 B
build/cart-blocks/empty-cart-frontend.js 346 B
build/cart-blocks/filled-cart-frontend.js 783 B
build/cart-blocks/order-summary-coupon-form-frontend.js 2.81 kB
build/cart-blocks/order-summary-discount-frontend.js 2.31 kB
build/cart-blocks/order-summary-fee-frontend.js 273 B
build/cart-blocks/order-summary-heading-frontend.js 454 B
build/cart-blocks/order-summary-shipping--checkout-blocks/order-summary-shipping-frontend.js 6.34 kB
build/cart-blocks/order-summary-shipping-frontend.js 428 B
build/cart-blocks/order-summary-subtotal-frontend.js 273 B
build/cart-blocks/order-summary-taxes-frontend.js 434 B
build/cart-blocks/proceed-to-checkout-frontend.js 1.16 kB
build/cart.js 44.3 kB
build/checkout-blocks/actions-frontend.js 1.41 kB
build/checkout-blocks/billing-address--checkout-blocks/shipping-address-frontend.js 4.12 kB
build/checkout-blocks/billing-address-frontend.js 892 B
build/checkout-blocks/contact-information-frontend.js 2.83 kB
build/checkout-blocks/express-payment-frontend.js 5.53 kB
build/checkout-blocks/fields-frontend.js 345 B
build/checkout-blocks/order-note-frontend.js 1.07 kB
build/checkout-blocks/order-summary-cart-items-frontend.js 3.67 kB
build/checkout-blocks/order-summary-coupon-form-frontend.js 2.96 kB
build/checkout-blocks/order-summary-discount-frontend.js 2.43 kB
build/checkout-blocks/order-summary-fee-frontend.js 275 B
build/checkout-blocks/order-summary-frontend.js 1.11 kB
build/checkout-blocks/order-summary-shipping-frontend.js 603 B
build/checkout-blocks/order-summary-subtotal-frontend.js 273 B
build/checkout-blocks/order-summary-taxes-frontend.js 433 B
build/checkout-blocks/payment-frontend.js 7.84 kB
build/checkout-blocks/shipping-address-frontend.js 997 B
build/checkout-blocks/shipping-methods-frontend.js 4.71 kB
build/checkout-blocks/terms-frontend.js 1.22 kB
build/checkout-blocks/totals-frontend.js 326 B
build/featured-category.js 12.1 kB
build/featured-product.js 10.6 kB
build/handpicked-products.js 7.11 kB
build/legacy-template.js 2.19 kB
build/mini-cart-contents-block/empty-cart-frontend.js 328 B
build/mini-cart-contents-block/filled-cart-frontend.js 230 B
build/mini-cart-contents-block/footer--mini-cart-contents-block/products-table-frontend.js 4.69 kB
build/mini-cart-contents-block/footer-frontend.js 5.63 kB
build/mini-cart-contents-block/items-frontend.js 225 B
build/mini-cart-contents-block/products-table-frontend.js 289 B
build/mini-cart-contents-block/shopping-button-frontend.js 287 B
build/mini-cart-contents-block/title-frontend.js 366 B
build/mini-cart-frontend.js 1.72 kB
build/mini-cart.js 6.09 kB
build/price-format.js 1.19 kB
build/product-add-to-cart--product-button--product-category-list--product-image--product-price--product-r--a0326d00.js 223 B
build/product-add-to-cart--product-button--product-image--product-title.js 2.65 kB
build/product-add-to-cart--product-button.js 564 B
build/product-add-to-cart-frontend.js 6.96 kB
build/product-add-to-cart.js 6.64 kB
build/product-best-sellers.js 7.38 kB
build/product-button--product-category-list--product-image--product-price--product-rating--product-sale-b--e17c7c01.js 500 B
build/product-button-frontend.js 1.84 kB
build/product-button.js 1.08 kB
build/product-categories.js 2.78 kB
build/product-category-list-frontend.js 925 B
build/product-category-list.js 501 B
build/product-category.js 8.49 kB
build/product-image-frontend.js 1.84 kB
build/product-image.js 1.07 kB
build/product-new.js 7.68 kB
build/product-on-sale.js 7.99 kB
build/product-price-frontend.js 1.94 kB
build/product-price.js 1.5 kB
build/product-rating-frontend.js 1.15 kB
build/product-rating.js 731 B
build/product-sale-badge-frontend.js 1.09 kB
build/product-sale-badge.js 680 B
build/product-search.js 2.18 kB
build/product-sku-frontend.js 380 B
build/product-sku.js 382 B
build/product-stock-indicator-frontend.js 1.03 kB
build/product-stock-indicator.js 620 B
build/product-summary-frontend.js 1.33 kB
build/product-summary.js 919 B
build/product-tag-list-frontend.js 920 B
build/product-tag-list.js 497 B
build/product-tag.js 7.81 kB
build/product-title-frontend.js 1.3 kB
build/product-title.js 909 B
build/product-top-rated.js 7.91 kB
build/products-by-attribute.js 8.39 kB
build/reviews-by-category.js 11.2 kB
build/reviews-frontend.js 7 kB
build/single-product.js 10 kB
build/stock-filter.js 6.91 kB
build/vendors--cart-blocks/cart-line-items--cart-blocks/cart-order-summary--cart-blocks/order-summary-shi--c02aad66-frontend.js 5.26 kB
build/vendors--cart-blocks/cart-line-items--checkout-blocks/order-summary-cart-items--mini-cart-contents---233ab542-frontend.js 3.14 kB
build/vendors--cart-blocks/order-summary-shipping--checkout-blocks/billing-address--checkout-blocks/order--5b8feb0b-frontend.js 4.75 kB
build/vendors--cart-blocks/order-summary-shipping--checkout-blocks/billing-address--checkout-blocks/order--decc3dc6-frontend.js 20.5 kB
build/vendors--mini-cart-contents-block/footer-frontend.js 6.86 kB
build/vendors--product-add-to-cart-frontend.js 7.53 kB
build/wc-blocks-data.js 9.87 kB
build/wc-blocks-editor-style-rtl.css 4.92 kB
build/wc-blocks-editor-style.css 4.92 kB
build/wc-blocks-google-analytics.js 1.56 kB
build/wc-blocks-middleware.js 930 B
build/wc-blocks-registry.js 2.7 kB
build/wc-blocks-shared-context.js 1.52 kB
build/wc-blocks-shared-hocs.js 1.14 kB
build/wc-blocks-style-rtl.css 22 kB
build/wc-blocks-style.css 22 kB
build/wc-blocks-vendors-style-rtl.css 1.28 kB
build/wc-blocks-vendors-style.css 1.28 kB
build/wc-blocks.js 2.63 kB
build/wc-payment-method-bacs.js 816 B
build/wc-payment-method-cheque.js 811 B
build/wc-payment-method-cod.js 909 B
build/wc-payment-method-paypal.js 837 B
build/wc-settings.js 2.61 kB

compressed-size-action

@Aljullu Aljullu mentioned this pull request Apr 27, 2022
Merged
tjcafferkey
tjcafferkey approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@tjcafferkey tjcafferkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. The bug only surfaces if you have a single Filter Products by Attribute block on the template so I updated the testing instructions to mention this.

Thanks for fixing 🙌🏻

@github-actions github-actions bot added this to the 7.5.0 milestone Apr 27, 2022
@Aljullu Aljullu modified the milestones: 7.5.0, 7.6.0 Apr 27, 2022
@Aljullu Aljullu requested a review from dinhtungdu April 27, 2022 13:20
dinhtungdu
dinhtungdu approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@dinhtungdu dinhtungdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested and found no regression as well. 🚢

@Aljullu
Copy link
Contributor Author

Aljullu commented Apr 28, 2022

Thanks for the reviews! Merging because failing e2e tests don't seem related to this PR.

@Aljullu Aljullu merged commit 64dc70e into trunk Apr 28, 2022
@Aljullu Aljullu deleted the fix/6331-attribute-filter-button-php-templates branch April 28, 2022 07:51
@opr opr mentioned this pull request May 10, 2022
Merged
@github-actions github-actions bot mentioned this pull request Jun 15, 2022
Closed
This was referenced Jul 4, 2022
Closed
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tjcafferkey tjcafferkey tjcafferkey approved these changes

@dinhtungdu dinhtungdu dinhtungdu approved these changes

Assignees

@Aljullu Aljullu

Labels
block: filter by attribute Issues related to the Filter by Attribute block. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Milestone
7.6.0
Development

Successfully merging this pull request may close these issues.

Filter Products by Attribute block with Filter button doesn't reload the page in PHP templates
3 participants
@Aljullu @dinhtungdu @tjcafferkey