This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Add new alt
attribute to the Featured Product
media settings
#6308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albarin
added
focus: components
Work that introduces new or updates existing components.
block: featured product
Issues related to the Featured Product block.
labels
Apr 25, 2022
rubikuserbot
requested review from
a team and
gigitux
and removed request for
a team
April 25, 2022 13:50
Size Change: +278 B (0%) Total Size: 870 kB
ℹ️ View Unchanged
|
sunyatasattva
suggested changes
Apr 26, 2022
Script Dependencies ReportThe
This comment was automatically generated by the |
Allow to define an alt text for the Feature Product block
Short description can contain html and images, so it's not adequate to use on the alt attribute
albarin
force-pushed
the
add/6235-media-controls-alt-text
branch
from
April 27, 2022 14:45
f8eda63
to
a2e272a
Compare
albarin
changed the title
Add new
Add new Apr 28, 2022
alt
attribute to Feature Product media settingsalt
attribute to the Featured Product
media settings
sunyatasattva
approved these changes
Apr 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
This was referenced Jul 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
block: featured product
Issues related to the Featured Product block.
focus: components
Work that introduces new or updates existing components.
type: enhancement
The issue is a request for an enhancement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows defining an
alt
text for theFeatured Product
block image.Fixes part of #6235
Testing
How to test the changes in this Pull Request:
Featured Product
.Media Settings
and check theAlt text
textarea appears empty.alt
text, save the block and check it renders on the frontend with the specifiedalt
text.alt
text and save it.alt
rendered on the frontend corresponds to the product name.Changelog