This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Graduate draft orders #6288
Merged
Graduate draft orders #6288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubikuserbot
requested review from
a team and
nielslange
and removed request for
a team
senadir
commented
Apr 20, 2022
Comment on lines
-50
to
-53
| } else { | ||
| // Maybe remove existing cronjob if present because it shouldn't be needed in the environment. | ||
| add_action( 'admin_init', [ $this, 'uninstall' ] ); | ||
| } |
There was a problem hiding this comment.
Removed this part and related things because we don't to remove cron jobs, this was a preventive workaround from the first accident around lost orders.
|
Size Change: 0 B Total Size: 869 kB ℹ️ View Unchanged
|
nielslange
approved these changes
Apr 21, 2022
There was a problem hiding this comment.
Pre-approving this.
I only have a minor concern regarding maybe_remove_cronjobs(), which had been removed. Wouldn't the current change allow a cronjob from being created, but never removed? Even when deactivating Woo Blocks in the future, this rouge cronjob would still be there. Shouldn't we make sure that all cronjobs, which we add, will also be removed, if no longer needed?
ralucaStan
reviewed
Apr 21, 2022
| @@ -55,7 +55,6 @@ We also have individual features or code blocks behind a feature flag, this is a | |||
|
|
|||
| ### Feature plugin flag | |||
|
|
|||
| - Draft order and cleanup process ([PHP flag](https://github.com/woocommerce/woocommerce-gutenberg-products-block/blob/e167b2c99c68e8113b4e371fefdd6f9a356ed2e8/src/Domain/Services/DraftOrders.php#L42-L51)). | |||
tarunvijwani
added
the
type: enhancement
senadir
added
type: bug
This was referenced Jul 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we moved Store API from the feature flag to the stable flag (so it's enabled in WooCommerce Core), we missed Draft orders, who were still behind a feature flag, this meant that if you tried to create an order via
POST /store/checkout, in WooCommerce Core (without blocks), the order created will be apending paymentorder, messing up the checkout process, and not getting validated by payment gateways.This PR has not testing instructions because we're simply enabling Draft orders in WooCommerce Core, unit tests should cover this.
Changelog