This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Filter Products by Attribute: Fix the page reload which happens when clicking the filter button on PHP templates #6287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjcafferkey
added
type: bug
|
Size Change: +137 B (0%) Total Size: 868 kB
ℹ️ View Unchanged
|
dinhtungdu
reviewed
Apr 21, 2022
There was a problem hiding this comment.
@tjcafferkey Thanks for the PR! I can confirm that the page doesn't reload anymore after selecting the attribute within the block with the filter button. But look like the issue with Active Filters is still there. In the screenshot below, only selected attributes from the Filter by Color block appear in the Active Filters block, Color filter doesn't have a filter button while the Size filter does:
…er button is not available
|
@dinhtungdu good catch, I've just pushed a commit to fix that! |
dinhtungdu
reviewed
Apr 21, 2022
There was a problem hiding this comment.
@tjcafferkey with 97a684c, the first issue comes back, please check my screencast for more detail. I tested with the Filter button enabled.
Screen.Recording.2022-04-21.at.17.51.55.mov
dinhtungdu
reviewed
Apr 21, 2022
There was a problem hiding this comment.
I got a weird behavior with the filter button enabled block:
- Enable the filter button for Filter Products by Attribute block.
- On the front end, select one or two attributes, and click the filter button.
- See the page reload: the filtered product result is correct, and the selected attributes appear in the Active Filters block => which are expected behaviors.
- The Filter Products by Attribute now only shows selected attributes, with product count set to
0. - In my case, I have another Filter block by another attribute (filter button disabled), that block disappears after the page load.
Screen.Recording.2022-04-21.at.22.58.39.mov
… for PHP templates
dinhtungdu
approved these changes
Apr 22, 2022
This was referenced Jul 5, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the page reload which is triggered immediately when you uncheck an attribute filter when the "Filter button" option is enabled.
Fixes #6283
Fixes #6282
Testing
Automated Tests
Manual Testing
How to test the changes in this Pull Request:
User Facing Testing
These are steps for user testing (where "user" is someone interacting with this change that is not editing any code).
Performance Impact
Changelog