This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Fix: Make Active Filters work with PHP templates #6252
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinhtungdu
added
type: enhancement
The issue is a request for an enhancement.
block: active filters
Issues related to the Active Filters block.
labels
Apr 14, 2022
Script Dependencies ReportThe
This comment was automatically generated by the |
Size Change: +325 B (0%) Total Size: 863 kB
ℹ️ View Unchanged
|
Close in favor of #6295. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
block: active filters
Issues related to the Active Filters block.
focus: FSE
Work related to prepare WooCommerce for FSE.
type: enhancement
The issue is a request for an enhancement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6138
This PR makes the Active Filters work with PHP templates. The idea is to update the current URL to remove the corresponding argument when users remove it from the Active Filters Block.
I used
updateFilterUrl
instead ofremoveArgsFromFilterUrl
because I want to use the same function for all types of filters:min_price
andmax_price
arguments from the URL.Screenshots
Testing
Automated Tests
Manual Testing
How to test the changes in this Pull Request:
User Facing Testing
These are steps for user testing (where "user" is someone interacting with this change that is not editing any code).
Performance Impact
Changelog