This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Pass correct number of arguments to woocommerce_blocks_checkout_update_cart_from_request
#6224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_order_from_request
opr
added
status: needs review
type: bug
The issue/PR concerns a confirmed bug.
focus: rest api
Work impacting REST api routes.
block: checkout
Issues related to the checkout block.
labels
Apr 11, 2022
rubikuserbot
requested review from
a team and
alexflorisca
and removed request for
a team
April 11, 2022 12:11
Size Change: 0 B Total Size: 861 kB ℹ️ View Unchanged
|
alexflorisca
approved these changes
Apr 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
Apr 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
block: checkout
Issues related to the checkout block.
focus: rest api
Work impacting REST api routes.
type: bug
The issue/PR concerns a confirmed bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will pass the correct arguments to the
woocommerce_blocks_checkout_update_order_from_request
action.This action was deprecated in #5992 and expects two arguments. In the call to
wc_do_deprecated_action
, only one argument was passed.Fixes #6133
Testing
Automated Tests
Manual Testing
How to test the changes in this Pull Request:
functions.php
file.User Facing Testing
These are steps for user testing (where "user" is someone interacting with this change that is not editing any code).
Changelog