This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Make Attribute Filter block compatible with PHP rendered Classic Template block #6204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjcafferkey
added
type: enhancement
Script Dependencies ReportThe
This comment was automatically generated by the |
|
Size Change: +1.24 kB (0%) Total Size: 863 kB
ℹ️ View Unchanged
|
Script Dependencies ReportThe
This comment was automatically generated by the |
|
Failing E2E tests appear unrelated. |
Aljullu
reviewed
Apr 7, 2022
There was a problem hiding this comment.
Overall this is looking good, but I found a couple of issues while testing:
First, I don't seem to be able to remove the last attribute filter, is that expected?
(it's not obvious from the GIF, but I'm pressing the checkbox and nothing happens 😅 )
The second one happens when I set the Display Style to Dropdown in the editor. The block crashes after I select one filter:
Can you reproduce them?
Script Dependencies ReportThe
This comment was automatically generated by the |
@Aljullu that's definitely not expected 😅 . I have fixed the crashing component just working on removal of filter now. |
…products-block into update/filter-product-by-attribute-php-template
Script Dependencies ReportThe
This comment was automatically generated by the |
…products-block into update/filter-product-by-attribute-php-template
Script Dependencies ReportThe
This comment was automatically generated by the |
Script Dependencies ReportThe
This comment was automatically generated by the |
|
I updated this PR with the fix for removing the filter. I noticed other three bugs:
This task was pretty trickier, I hope that I didn't introduce new bugs :D |
Aljullu
reviewed
Apr 12, 2022
Yes, thanks for catching this! I'm working on a fix! |
gigitux
force-pushed
the
update/filter-product-by-attribute-php-template
branch
from
f5a4ff9 to
0bdf8a7
Compare
|
Fixed with 0bdf8a7 |
Script Dependencies ReportThe
This comment was automatically generated by the |
2 similar comments
Script Dependencies ReportThe
This comment was automatically generated by the |
Script Dependencies ReportThe
This comment was automatically generated by the |
albarin
approved these changes
Apr 13, 2022
…products-block into update/filter-product-by-attribute-php-template
Script Dependencies ReportThe
This comment was automatically generated by the |
Script Dependencies ReportThe
This comment was automatically generated by the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Filter Attribute block to work with the Classic Template block which is PHP rendered, but also still maintain compatibility with the All Products block.
Filter Products by Attribute block will only work with the PHP rendered Classic Template block if the filters are applied to the URL and the page is re-rendered. This behaviour happens with the Classic Themes such as Storefront.
Fixes #6136
Testing
Automated Tests
Manual Testing
How to test the changes in this Pull Request:
All Productsblock, and theFilter by Attributeblock and ensure no regressions have been introduced here.User Facing Testing
These are steps for user testing (where "user" is someone interacting with this change that is not editing any code).
Changelog