This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix/e2e tests timeout issue #6165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexflorisca
added
skip-changelog
rubikuserbot
requested review from
a team and
opr
and removed request for
a team
|
Size Change: 0 B Total Size: 874 kB ℹ️ View Unchanged
|
gigitux
force-pushed
the
fix/e2e-tests-timeout-issue
branch
2 times, most recently
from
142da89 to
815c2f2
Compare
alexflorisca
force-pushed
the
fix/e2e-tests-timeout-issue
branch
from
02717cd to
d27157f
Compare
|
Fixed flakey tests. The remaining failing test here is due to an actual bug on trunk where some of the cart inner blocks do not show up |
alexflorisca
force-pushed
the
fix/e2e-tests-timeout-issue
branch
from
353ed3a to
199401d
Compare
opr
reviewed
Apr 7, 2022
There was a problem hiding this comment.
The network will be idle while the blocks are loading anyway won't it? The client-side rendering could take time, but won't necessarily be using the network. Moreover it doesn't look like this was actually added, so maybe we need to update the PR description?
|
Sorry @opr, there's been a lot of trial and error with this PR, I've updated the PR description now |
opr
approved these changes
Apr 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the tests were failing due to importing the wrong constant (
SIMPLE_PRODUCT_NAMEinstead ofSIMPLE_VIRTUAL_PRODUCT_NAME).Translation tests were failing randomly because the block hadn't finished loading when the assertions were being made. @gigitux added an extra
waitForSelectorhere to wait for the cart to load.I also realised that the translation tests are failing for legitimate reasons, which are being addressed in this PR
Testing