This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Add Inner blocks to order summary #6065
Merged
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
a6e069a
Sub/Total/Fee inner blocks
mikejolley 4240f52
Row blocks within the inner block
mikejolley c089588
Update icons
mikejolley fce5143
Resolve stying issues
mikejolley ef752e3
Remove old block
mikejolley 58c41ad
Pin totals row
mikejolley 1fef92d
Locking logic update
mikejolley 4a5bf74
Heading inner block
mikejolley f049f47
Refactor where inner blocks are defined
mikejolley e1d8962
Add todos
mikejolley f4fdfc0
Todo for Consider deprecating OrderMetaSlotFill and DiscountSlotFill …
mikejolley 807ac42
Improve frontend registration of components using new entrypoint
mikejolley 0bfe5cf
Experiment- external block context
mikejolley f88c680
Revert "Experiment- external block context"
mikejolley c28ad41
Duplicate inner blocks to avoid conflicts with context
mikejolley 6e012e3
Remove todo
mikejolley 23fe5e1
Rename block dir
mikejolley 6f291f5
Some test fixes
mikejolley 614ec92
Fix import
mikejolley 3a4ba59
fix import
mikejolley 36415b6
linting
mikejolley 217def8
Remove unused attributes
mikejolley 7c9af1b
Optional classname
mikejolley 03e804c
fix coupons import
senadir ff09db0
fix shipping mocks
senadir f07710f
Styling
mikejolley 2ce7720
Fix selectors in e2e tests
mikejolley 1067039
Add back the wc-block-components-totals-wrapper class that was used f…
ralucaStan d654f5b
Reuse the TotalsWrapper component for C& C blocks inner blocks
ralucaStan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
125 changes: 0 additions & 125 deletions
125
assets/js/blocks/cart-checkout/cart/inner-blocks/cart-order-summary-block/block.tsx
This file was deleted.
Oops, something went wrong.
122 changes: 0 additions & 122 deletions
122
assets/js/blocks/cart-checkout/cart/inner-blocks/register-components.ts
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
6 changes: 6 additions & 0 deletions
6
assets/js/blocks/cart/inner-blocks/cart-express-payment-block/frontend.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
/** | ||
* Internal dependencies | ||
*/ | ||
import Block from './block'; | ||
|
||
export default Block; |
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
6 changes: 6 additions & 0 deletions
6
assets/js/blocks/cart/inner-blocks/cart-line-items-block/frontend.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
/** | ||
* Internal dependencies | ||
*/ | ||
import Block from './block'; | ||
|
||
export default Block; |
File renamed without changes.
File renamed without changes.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before we had the
.wc-block-components-totals-wrapper
class for each item of the summary.Now:
.wc-block-components-totals-wrapper
class only for slots.wc-block-components-totals-item
for some of the items.wc-block-components-totals-item
and it needs to be styled separately.I think it was good to have one class for each of this summary items. I wonder why:
.wc-block-components-totals-wrapper
?.wc-block-components-totals-item
to coupon, summary and shipping as well?