This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Update innerBlock template for Featured Product and Featured Category blocks #5867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… blocks #5676 update innerBlock template for Featured Product and Featured Category blocks
gigitux
added
type: bug
The issue/PR concerns a confirmed bug.
block: featured category
Issues related to the Featured Category block,
block: featured product
Issues related to the Featured Product block.
labels
Feb 16, 2022
rubikuserbot
requested review from
a team and
frontdevde
and removed request for
a team
February 16, 2022 16:16
Size Change: +14 B (0%) Total Size: 816 kB
ℹ️ View Unchanged
|
Nice! This also fixed a bug where
|
tomasztunik
approved these changes
Feb 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌 looks good
To get the align and width to work we have to set align to none
and use justify setting to control left | center | right
position
3 tasks
frontdevde
added
the
skip-changelog
PRs that you don't want to appear in the changelog.
label
Feb 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
block: featured category
Issues related to the Featured Category block,
block: featured product
Issues related to the Featured Product block.
skip-changelog
PRs that you don't want to appear in the changelog.
type: bug
The issue/PR concerns a confirmed bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the inner block template for Featured Product and Featured Category. This is necessary because a button block should have as the parent the buttons block. In this way, the user is able to customize again:
NOTE: The width is customizable only when the alignment is set to
none
. This is the default behavior on Gutenberg.Fixes #5676
Screenshots
Testing
Manual Testing
How to test the changes in this Pull Request:
User Facing Testing
These are steps for user testing (where "user" is someone interacting with this change that is not editing any code).
Changelog