Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Spread metadata to allow default attributes to work when loading Checkout block in frontend #5732

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

opr
Copy link
Contributor

@opr opr commented Feb 7, 2022

This PR ensures default attributes from metadata are passed to the front end block.

Fixes #5723

Testing

Automated Tests

  • Changes in this PR are covered by Automated Tests.
    • Unit tests
    • E2E tests

Manual Testing

How to test the changes in this Pull Request:

  1. Add the Checkout block and select the Shipping Address in the editor.
  2. Change the settings (try a few different, random settings) in the sidebar and ensure the block changes as expected.
  3. Save the block and load it on the front-end and ensure the block is rendered as you expect based on the attributes you saved.
  4. Go back to the editor and select the Checkout block as a whole, set the "Dark mode inputs" option to true.
  5. Load the block in the front-end again and ensure the dark mode inputs are being used.

User Facing Testing

These are steps for user testing (where "user" is someone interacting with this change that is not editing any code).

  • Same as above, or
  • See steps below.

Changelog

Fixed an issue where default block attributes were not being passed to the Checkout block correctly.

@opr opr added status: needs review focus: blocks Specific work involving or impacting how blocks behave. block: checkout Issues related to the checkout block. labels Feb 7, 2022
@opr opr self-assigned this Feb 7, 2022
@rubikuserbot rubikuserbot requested review from a team and nielslange and removed request for a team February 7, 2022 12:16
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2022

Size Change: +126 B (0%)

Total Size: 813 kB

Filename Size Change
build/active-filters-frontend.js 6.37 kB +1 B (0%)
build/all-products-frontend.js 18.7 kB -3 B (0%)
build/atomic-block-components/add-to-cart-frontend.js 6.89 kB -2 B (0%)
build/atomic-block-components/button-frontend.js 1.48 kB +2 B (0%)
build/atomic-block-components/category-list-frontend.js 457 B -1 B (0%)
build/atomic-block-components/price-frontend.js 1.74 kB +2 B (0%)
build/atomic-block-components/stock-indicator-frontend.js 939 B -1 B (0%)
build/atomic-block-components/summary-frontend.js 1.24 kB +1 B (0%)
build/atomic-block-components/tag-list-frontend.js 460 B +1 B (0%)
build/atomic-block-components/title-frontend.js 1.21 kB +3 B (0%)
build/cart-blocks/accepted-payment-methods-frontend.js 1.14 kB -1 B (0%)
build/cart-blocks/empty-cart-frontend.js 345 B -1 B (0%)
build/cart-blocks/items-frontend.js 299 B +1 B (0%)
build/cart-blocks/line-items-frontend.js 5.49 kB -1 B (0%)
build/cart-blocks/order-summary-frontend.js 8.94 kB -10 B (0%)
build/cart-blocks/totals-frontend.js 320 B -1 B (0%)
build/cart-frontend.js 45.5 kB +4 B (0%)
build/checkout-blocks/actions-frontend.js 1.39 kB -1 B (0%)
build/checkout-blocks/contact-information-frontend.js 2.95 kB -2 B (0%)
build/checkout-blocks/express-payment-frontend.js 5.46 kB -1 B (0%)
build/checkout-blocks/fields-frontend.js 344 B +1 B (0%)
build/checkout-blocks/order-note-frontend.js 1.13 kB +1 B (0%)
build/checkout-blocks/order-summary-frontend.js 11.4 kB -10 B (0%)
build/checkout-blocks/payment-frontend.js 7.71 kB +1 B (0%)
build/checkout-blocks/shipping-address-frontend.js 975 B +1 B (0%)
build/checkout-blocks/shipping-methods-frontend.js 4.92 kB +3 B (0%)
build/checkout-blocks/totals-frontend.js 324 B +1 B (0%)
build/checkout-frontend.js 47.6 kB +129 B (0%)
build/mini-cart-component-frontend.js 14.3 kB +3 B (0%)
build/mini-cart-frontend.js 1.78 kB +2 B (0%)
build/price-filter-frontend.js 12.6 kB +1 B (0%)
build/reviews-frontend.js 7.35 kB -1 B (0%)
build/single-product-frontend.js 22.2 kB +3 B (0%)
build/stock-filter-frontend.js 6.61 kB -2 B (0%)
build/vendors--atomic-block-components/add-to-cart--cart-blocks/order-summary--checkout-blocks/billing-ad--c5eb4dcd-frontend.js 19 kB +2 B (0%)
build/vendors--atomic-block-components/add-to-cart-frontend.js 7.51 kB +1 B (0%)
build/vendors--cart-blocks/line-items--checkout-blocks/order-summary-frontend.js 3.14 kB -1 B (0%)
build/vendors--cart-blocks/order-summary--checkout-blocks/billing-address--checkout-blocks/order-summary---eb4d2cec-frontend.js 4.74 kB +1 B (0%)
ℹ️ View Unchanged
Filename Size
build/active-filters.js 7.05 kB
build/all-products.js 33.8 kB
build/all-reviews.js 8.06 kB
build/atomic-block-components/add-to-cart--atomic-block-components/button--atomic-block-components/image---8f355022.js 255 B
build/atomic-block-components/add-to-cart--atomic-block-components/button--atomic-block-components/image---a7e2bb9b.js 2.67 kB
build/atomic-block-components/add-to-cart--atomic-block-components/button.js 1.48 kB
build/atomic-block-components/add-to-cart.js 6.46 kB
build/atomic-block-components/button.js 853 B
build/atomic-block-components/category-list.js 459 B
build/atomic-block-components/image-frontend.js 1.37 kB
build/atomic-block-components/image.js 1.05 kB
build/atomic-block-components/price.js 1.7 kB
build/atomic-block-components/rating-frontend.js 703 B
build/atomic-block-components/rating.js 700 B
build/atomic-block-components/sale-badge-frontend.js 625 B
build/atomic-block-components/sale-badge.js 624 B
build/atomic-block-components/sku-frontend.js 386 B
build/atomic-block-components/sku.js 386 B
build/atomic-block-components/stock-indicator--atomic-block-components/summary--atomic-block-components/title.js 468 B
build/atomic-block-components/stock-indicator.js 623 B
build/atomic-block-components/summary.js 926 B
build/atomic-block-components/tag-list.js 459 B
build/atomic-block-components/title.js 935 B
build/attribute-filter-frontend.js 16.8 kB
build/attribute-filter.js 13.1 kB
build/blocks-checkout.js 17.6 kB
build/cart-blocks/checkout-button-frontend.js 1.14 kB
build/cart-blocks/express-payment-frontend.js 5.18 kB
build/cart-blocks/filled-cart-frontend.js 766 B
build/cart.js 43.7 kB
build/checkout-blocks/billing-address--checkout-blocks/shipping-address-frontend.js 4.23 kB
build/checkout-blocks/billing-address-frontend.js 887 B
build/checkout-blocks/terms-frontend.js 1.22 kB
build/checkout.js 45.2 kB
build/featured-category.js 8.61 kB
build/featured-product.js 9.62 kB
build/handpicked-products.js 7.09 kB
build/legacy-template.js 2.18 kB
build/mini-cart-contents.js 3.82 kB
build/mini-cart.js 6.39 kB
build/price-filter.js 8.51 kB
build/price-format.js 1.18 kB
build/product-best-sellers.js 7.37 kB
build/product-categories.js 3.17 kB
build/product-category.js 8.49 kB
build/product-new.js 7.66 kB
build/product-on-sale.js 7.99 kB
build/product-search.js 2.18 kB
build/product-tag.js 7.8 kB
build/product-top-rated.js 7.9 kB
build/products-by-attribute.js 8.39 kB
build/reviews-by-category.js 11.5 kB
build/reviews-by-product.js 12.6 kB
build/single-product.js 10 kB
build/stock-filter.js 6.68 kB
build/vendors--atomic-block-components/price--cart-blocks/line-items--cart-blocks/order-summary--checkout--8a3571de-frontend.js 5.71 kB
build/wc-blocks-data.js 8.84 kB
build/wc-blocks-editor-style-rtl.css 4.79 kB
build/wc-blocks-editor-style.css 4.79 kB
build/wc-blocks-google-analytics.js 1.56 kB
build/wc-blocks-middleware.js 949 B
build/wc-blocks-registry.js 2.7 kB
build/wc-blocks-shared-context.js 1.52 kB
build/wc-blocks-shared-hocs.js 1.14 kB
build/wc-blocks-style-rtl.css 21.9 kB
build/wc-blocks-style.css 21.9 kB
build/wc-blocks-vendors-style-rtl.css 1.28 kB
build/wc-blocks-vendors-style.css 1.28 kB
build/wc-blocks-vendors.js 69.7 kB
build/wc-blocks.js 2.62 kB
build/wc-payment-method-bacs.js 816 B
build/wc-payment-method-cheque.js 811 B
build/wc-payment-method-cod.js 909 B
build/wc-payment-method-paypal.js 837 B
build/wc-settings.js 2.61 kB

compressed-size-action

Copy link
Member

@nielslange nielslange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢

@github-actions github-actions bot added this to the 7.0.0 milestone Feb 8, 2022
@opr opr merged commit 7579cbb into trunk Feb 8, 2022
@opr opr deleted the fix/attributes-in-checkout branch February 8, 2022 10:33
@sunyatasattva sunyatasattva added the type: bug The issue/PR concerns a confirmed bug. label Feb 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: checkout Issues related to the checkout block. focus: blocks Specific work involving or impacting how blocks behave. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

phone field and bulding / apartment can no longer be deactivated
3 participants