This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Update Checkout block E2E fixture and increase node version in GH actions #5678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubikuserbot
requested review from
a team and
alexflorisca
and removed request for
a team
January 31, 2022 12:25
Size Change: +71 kB (+10%) Total Size: 816 kB
ℹ️ View Unchanged
|
opr
force-pushed
the
try/record-screen
branch
4 times, most recently
from
January 31, 2022 22:05
89aa92b
to
915fb18
Compare
opr
force-pushed
the
try/record-screen
branch
from
January 31, 2022 22:12
915fb18
to
62db707
Compare
opr
added
category: tests
skip-changelog
PRs that you don't want to appear in the changelog.
block: checkout
Issues related to the checkout block.
block-type: reviews
Issues related to all of the reviews related blocks.
labels
Jan 31, 2022
opr
changed the title
[Testing PR] Try recording e2e run in video
Update Checkout block E2E fixture and increase node version in GH actions
Jan 31, 2022
opr
added
status: needs review
and removed
block-type: reviews
Issues related to all of the reviews related blocks.
labels
Jan 31, 2022
nielslange
added
the
status: blocker
Used on issues or pulls that block work from being released.
label
Feb 1, 2022
I added the label |
alexflorisca
approved these changes
Feb 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve 🙇 . Good work, I know this was a bit of a pain to work on!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
block: checkout
Issues related to the checkout block.
skip-changelog
PRs that you don't want to appear in the changelog.
status: blocker
Used on issues or pulls that block work from being released.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following changes:
Setup
step from the E2E tests action. This was unnecessary, the node modules were not shared between runs so it was just wasting time.Testing
Automated Tests
Manual Testing
How to test the changes in this Pull Request:
User Facing Testing
There are no user-facing tests required for this PR.
Changelog