Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Update Checkout block E2E fixture and increase node version in GH actions #5678

Merged
merged 6 commits into from
Feb 1, 2022

Conversation

opr
Copy link
Contributor

@opr opr commented Jan 31, 2022

This PR includes the following changes:

  • Change the Checkout fixture for E2E tests to include the inner blocks.
  • Update the node version used in the E2E action to 16.
  • Remove the Setup step from the E2E tests action. This was unnecessary, the node modules were not shared between runs so it was just wasting time.
  • Ensure storefront is installed in wp-env.

Testing

Automated Tests

  • Changes in this PR are covered by Automated Tests.
    • Unit tests
    • E2E tests

Manual Testing

How to test the changes in this Pull Request:

  1. Ensure tests pass in CI.

User Facing Testing

There are no user-facing tests required for this PR.

Changelog

Skipping

@rubikuserbot rubikuserbot requested review from a team and alexflorisca and removed request for a team January 31, 2022 12:25
@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2022

Size Change: +71 kB (+10%) ⚠️

Total Size: 816 kB

Filename Size Change
build/active-filters-frontend.js 6.24 kB +21 B (0%)
build/active-filters.js 7.08 kB +6 B (0%)
build/all-products-frontend.js 18.7 kB +44 B (0%)
build/all-products.js 35.2 kB +110 B (0%)
build/all-reviews.js 8.43 kB +42 B (+1%)
build/atomic-block-components/add-to-cart--atomic-block-components/button--atomic-block-components/image---a7e2bb9b.js 2.67 kB -6 B (0%)
build/atomic-block-components/add-to-cart--atomic-block-components/button.js 1.48 kB +3 B (0%)
build/atomic-block-components/add-to-cart-frontend.js 7.05 kB +7 B (0%)
build/atomic-block-components/add-to-cart.js 6.62 kB +18 B (0%)
build/atomic-block-components/button-frontend.js 1.48 kB -2 B (0%)
build/atomic-block-components/button.js 851 B -3 B (0%)
build/atomic-block-components/category-list.js 460 B +2 B (0%)
build/atomic-block-components/image.js 1.05 kB -2 B (0%)
build/atomic-block-components/price-frontend.js 1.74 kB +3 B (0%)
build/atomic-block-components/price.js 1.7 kB +3 B (0%)
build/atomic-block-components/rating-frontend.js 699 B -4 B (-1%)
build/atomic-block-components/rating.js 699 B -1 B (0%)
build/atomic-block-components/sale-badge.js 622 B -2 B (0%)
build/atomic-block-components/sku.js 386 B +2 B (+1%)
build/atomic-block-components/stock-indicator-frontend.js 924 B -2 B (0%)
build/atomic-block-components/summary-frontend.js 1.22 kB -3 B (0%)
build/atomic-block-components/tag-list-frontend.js 460 B +1 B (0%)
build/atomic-block-components/tag-list.js 459 B +1 B (0%)
build/atomic-block-components/title-frontend.js 1.2 kB +9 B (+1%)
build/attribute-filter-frontend.js 16.4 kB +22 B (0%)
build/attribute-filter.js 12.6 kB +6 B (0%)
build/cart-blocks/accepted-payment-methods-frontend.js 1.14 kB +2 B (0%)
build/cart-blocks/checkout-button-frontend.js 1.14 kB -3 B (0%)
build/cart-blocks/express-payment-frontend.js 4.86 kB +130 B (+3%)
build/cart-blocks/filled-cart-frontend.js 767 B +54 B (+8%) 🔍
build/cart-blocks/items-frontend.js 299 B +22 B (+8%) 🔍
build/cart-blocks/line-items-frontend.js 5.49 kB +228 B (+4%)
build/cart-blocks/order-summary-frontend.js 8.97 kB +354 B (+4%)
build/cart-blocks/totals-frontend.js 321 B +27 B (+9%) 🔍
build/cart-frontend.js 45.5 kB +45 B (0%)
build/cart.js 44.6 kB +804 B (+2%)
build/checkout-frontend.js 47.5 kB +2.23 kB (+5%) 🔍
build/checkout.js 47.1 kB +24.4 kB (+108%) 🆘
build/featured-category.js 8.64 kB +13 B (0%)
build/featured-product.js 9.9 kB -11 B (0%)
build/handpicked-products.js 7.33 kB +13 B (0%)
build/legacy-template.js 2.19 kB +27 B (+1%)
build/mini-cart-component-frontend.js 14.3 kB +90 B (+1%)
build/mini-cart-contents.js 3.6 kB +29 B (+1%)
build/mini-cart.js 6.46 kB +26 B (0%)
build/price-filter-frontend.js 12.6 kB +18 B (0%)
build/price-filter.js 8.91 kB +22 B (0%)
build/product-best-sellers.js 7.54 kB +13 B (0%)
build/product-categories.js 3.45 kB +23 B (+1%)
build/product-category.js 8.68 kB +14 B (0%)
build/product-new.js 7.99 kB +11 B (0%)
build/product-on-sale.js 8.36 kB +16 B (0%)
build/product-search.js 2.47 kB -2 B (0%)
build/product-tag.js 8.08 kB +15 B (0%)
build/product-top-rated.js 7.96 kB +17 B (0%)
build/products-by-attribute.js 8.79 kB +16 B (0%)
build/reviews-by-category.js 11.9 kB +31 B (0%)
build/reviews-by-product.js 13 kB +48 B (0%)
build/reviews-frontend.js 7.36 kB +18 B (0%)
build/single-product-frontend.js 22.2 kB +41 B (0%)
build/single-product.js 10.5 kB +12 B (0%)
build/stock-filter-frontend.js 6.82 kB +23 B (0%)
build/stock-filter.js 6.82 kB +6 B (0%)
build/vendors--atomic-block-components/add-to-cart--cart-blocks/order-summary-frontend.js 0 B -19 kB (removed) 🏆
build/vendors--atomic-block-components/add-to-cart-frontend.js 7.44 kB +16 B (0%)
build/vendors--atomic-block-components/price--cart-blocks/line-items--cart-blocks/order-summary-frontend.js 0 B -5.71 kB (removed) 🏆
build/vendors--cart-blocks/line-items-frontend.js 0 B -3.33 kB (removed) 🏆
build/vendors--cart-blocks/order-summary-frontend.js 0 B -4.75 kB (removed) 🏆
build/wc-blocks-vendors.js 65.5 kB -138 B (0%)
build/wc-blocks.js 2.96 kB -1 B (0%)
build/checkout-blocks/actions-frontend.js 1.44 kB +1.44 kB (new file) 🆕
build/checkout-blocks/billing-address--checkout-blocks/shipping-address-frontend.js 4.22 kB +4.22 kB (new file) 🆕
build/checkout-blocks/billing-address-frontend.js 887 B +887 B (new file) 🆕
build/checkout-blocks/contact-information-frontend.js 2.94 kB +2.94 kB (new file) 🆕
build/checkout-blocks/express-payment-frontend.js 5.15 kB +5.15 kB (new file) 🆕
build/checkout-blocks/fields-frontend.js 344 B +344 B (new file) 🆕
build/checkout-blocks/order-note-frontend.js 1.13 kB +1.13 kB (new file) 🆕
build/checkout-blocks/order-summary-frontend.js 11.4 kB +11.4 kB (new file) 🆕
build/checkout-blocks/payment-frontend.js 7.39 kB +7.39 kB (new file) 🆕
build/checkout-blocks/shipping-address-frontend.js 973 B +973 B (new file) 🆕
build/checkout-blocks/shipping-methods-frontend.js 4.81 kB +4.81 kB (new file) 🆕
build/checkout-blocks/terms-frontend.js 1.22 kB +1.22 kB (new file) 🆕
build/checkout-blocks/totals-frontend.js 324 B +324 B (new file) 🆕
build/vendors--atomic-block-components/add-to-cart--cart-blocks/order-summary--checkout-blocks/billing-ad--c5eb4dcd-frontend.js 19 kB +19 kB (new file) 🆕
build/vendors--atomic-block-components/price--cart-blocks/line-items--cart-blocks/order-summary--checkout--8a3571de-frontend.js 5.71 kB +5.71 kB (new file) 🆕
build/vendors--cart-blocks/line-items--checkout-blocks/order-summary-frontend.js 3.14 kB +3.14 kB (new file) 🆕
build/vendors--cart-blocks/order-summary--checkout-blocks/billing-address--checkout-blocks/order-summary---eb4d2cec-frontend.js 4.74 kB +4.74 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size
build/atomic-block-components/add-to-cart--atomic-block-components/button--atomic-block-components/image---8f355022.js 238 B
build/atomic-block-components/category-list-frontend.js 458 B
build/atomic-block-components/image-frontend.js 1.37 kB
build/atomic-block-components/sale-badge-frontend.js 624 B
build/atomic-block-components/sku-frontend.js 386 B
build/atomic-block-components/stock-indicator--atomic-block-components/summary--atomic-block-components/title.js 452 B
build/atomic-block-components/stock-indicator.js 624 B
build/atomic-block-components/summary.js 925 B
build/atomic-block-components/title.js 932 B
build/blocks-checkout.js 17.6 kB
build/cart-blocks/empty-cart-frontend.js 345 B
build/mini-cart-frontend.js 1.76 kB
build/price-format.js 1.18 kB
build/wc-blocks-data.js 8.84 kB
build/wc-blocks-editor-style-rtl.css 4.7 kB
build/wc-blocks-editor-style.css 4.7 kB
build/wc-blocks-google-analytics.js 1.56 kB
build/wc-blocks-middleware.js 949 B
build/wc-blocks-registry.js 2.7 kB
build/wc-blocks-shared-context.js 1.52 kB
build/wc-blocks-shared-hocs.js 1.14 kB
build/wc-blocks-style-rtl.css 21.8 kB
build/wc-blocks-style.css 21.8 kB
build/wc-blocks-vendors-style-rtl.css 1.28 kB
build/wc-blocks-vendors-style.css 1.28 kB
build/wc-payment-method-bacs.js 816 B
build/wc-payment-method-cheque.js 811 B
build/wc-payment-method-cod.js 909 B
build/wc-payment-method-paypal.js 837 B
build/wc-settings.js 2.61 kB

compressed-size-action

@opr opr force-pushed the try/record-screen branch 4 times, most recently from 89aa92b to 915fb18 Compare January 31, 2022 22:05
@opr opr force-pushed the try/record-screen branch from 915fb18 to 62db707 Compare January 31, 2022 22:12
@opr opr added category: tests skip-changelog PRs that you don't want to appear in the changelog. block: checkout Issues related to the checkout block. block-type: reviews Issues related to all of the reviews related blocks. labels Jan 31, 2022
@opr opr changed the title [Testing PR] Try recording e2e run in video Update Checkout block E2E fixture and increase node version in GH actions Jan 31, 2022
@opr opr added status: needs review and removed block-type: reviews Issues related to all of the reviews related blocks. labels Jan 31, 2022
@nielslange nielslange added the status: blocker Used on issues or pulls that block work from being released. label Feb 1, 2022
@nielslange nielslange added this to the 6.9.0 milestone Feb 1, 2022
@nielslange
Copy link
Member

I added the label type: blocker as this PR ensures that the checkout block can be rendered correctly.

Copy link
Member

@alexflorisca alexflorisca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve 🙇 . Good work, I know this was a bit of a pain to work on!

@alexflorisca alexflorisca merged commit 4dc24cc into trunk Feb 1, 2022
@alexflorisca alexflorisca deleted the try/record-screen branch February 1, 2022 11:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: checkout Issues related to the checkout block. skip-changelog PRs that you don't want to appear in the changelog. status: blocker Used on issues or pulls that block work from being released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants