This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Summary Product block: Add support for global style #5524
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mmerce-gutenberg-products-block into add/4965-summary
Summary Product block: add support for global style
gigitux
added
type: enhancement
The issue is a request for an enhancement.
block: all products
Issues related to the all products block.
block: single product
Issues related to the single product block.
focus: global styles
Issues that involve styles/css/layout structure.
focus: FSE
Work related to prepare WooCommerce for FSE.
labels
Jan 6, 2022
rubikuserbot
requested review from
a team and
sunyatasattva
and removed request for
a team
January 6, 2022 10:51
gigitux
added
the
status: blocked
The issue is blocked from progressing, waiting for another piece of work to be done.
label
Jan 6, 2022
Size Change: +1.13 kB (0%) Total Size: 816 kB
ℹ️ View Unchanged
|
gigitux
changed the title
Summary Product block: Add support for global style #5521
Summary Product block: Add support for global style
Jan 6, 2022
18 tasks
…products-block into add/4965-summary
gigitux
removed
the
status: blocked
The issue is blocked from progressing, waiting for another piece of work to be done.
label
Jan 12, 2022
sunyatasattva
suggested changes
Jan 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small typo, everything else LGTM
const { parentClassName } = useInnerBlockLayoutContext(); | ||
const { product } = useProductDataContext(); | ||
const colorProps = useColorProps( props ); | ||
const typograhyProps = useTypographyProps( props ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in typography
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
sunyatasattva
approved these changes
Jan 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
block: all products
Issues related to the all products block.
block: single product
Issues related to the single product block.
focus: FSE
Work related to prepare WooCommerce for FSE.
focus: global styles
Issues that involve styles/css/layout structure.
type: enhancement
The issue is a request for an enhancement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is blocked by #5515This PR adds support for global style for the
Summary Product block
.Now, the user can edit the style for:
#4965
Screenshots
without global style
with global style
Testing
Manual Testing
Check out this branch:
WordPress 5.9
, install and enable the Gutenberg plugin.Twenty Twenty-Two
theme.Single Product block
(this block containsSummary Product block
) to a post.Summary Product block
.Reset
button from the different sections.Styles
icon on the right-top corner.Summary Product block
is shown under theBlocks
section. Personalize again the block.Changelog