This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Category List block: add support for global style #5516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mmerce-gutenberg-products-block into add/4965-category-list
Enable global style for category list block
gigitux
added
block: single product
rubikuserbot
requested review from
a team and
tjcafferkey
and removed request for
a team
gigitux
added
the
status: blocked
|
Size Change: +1.07 kB (0%) Total Size: 816 kB
ℹ️ View Unchanged
|
18 tasks
…products-block into add/4965-category-list
gigitux
removed
the
status: blocked
dinhtungdu
approved these changes
Feb 13, 2022
| @@ -39,10 +47,12 @@ const Block = ( { className }: Props ): JSX.Element | null => { | |||
| className={ classnames( | |||
| className, | |||
| 'wc-block-components-product-category-list', | |||
| colorProps.className, | |||
There was a problem hiding this comment.
Even colorProps.className can be undefined, we don't need to check for its value because undefined is an expected value and will be skipped by classnames().
sunyatasattva
added
the
type: enhancement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is blocked by #5515This PR adds support for global style for the component Product Title.
Now, the user can edit the style for:
Fixes #4965
Screenshots
without global style
with global style
Testing
Manual Testing
Check out this branch:
WordPress 5.9, install and enable theGutenbergplugin.Twenty Twenty-Twotheme.Single Product block(this block containsProduct Title Block) to a post.Category List Block.Resetbutton from the different sections.Stylesicon on the right-top corner.Category List Blockis shown under theBlockssection. Personalize again the block.Changelog