This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Mini Cart Contents: Fix missing custom background #5448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigitux
added
focus: FSE
rubikuserbot
requested review from
a team and
dinhtungdu
and removed request for
a team
|
Size Change: 0 B Total Size: 819 kB ℹ️ View Unchanged
|
…products-block into fix/5416-mini-cart-background-gutenberg
Aljullu
reviewed
Dec 29, 2021
src/Utils/BlockTemplateUtils.php
Outdated
| * | ||
| * @return WP_Block_Template|null Template. | ||
| */ | ||
| public static function fse_get_block_template( $id, $template_type ) { |
There was a problem hiding this comment.
I'm not sure about the fse prefix... 🤔 I would just call it get_block_template like in WP core or wc_get_block_template if we want to make it clear it's WC-specific.
There was a problem hiding this comment.
Yes, it makes sense!
There was a problem hiding this comment.
I would call it get_block_template as well, we already have BlockTemplateUtils as the prefix.
As we already discussed in our internal channel, maybe before adopting this utility globally it is better to investigate why there is this different behavior even if both functions should do the same thing. This can require a little bit of time :( |
Sounds good! Do you know if we have an issue for that? It would be good adding it to the Template Editing v2 epic so we don't forget. |
No, it was my intention to create it after checking with you. |
…products-block into fix/5416-mini-cart-background-gutenberg
from my side. 🙂
gigitux
added
skip-changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR using WordPress 5.9 beta, with the Gutenberg disabled, is visible the custom background if it is set.
Fixes #5416
Testing
Manual Testing
Check out this branch