This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigitux
added
type: bug
The issue/PR concerns a confirmed bug.
skip-changelog
PRs that you don't want to appear in the changelog.
focus: FSE
Work related to prepare WooCommerce for FSE.
focus: template
Related to API powering block template functionality in the Site Editor
labels
Dec 17, 2021
Revert theme name #5411
gigitux
force-pushed
the
fix/revert-plugin-name-rest
branch
from
December 17, 2021 15:47
111e8d9
to
822308c
Compare
Size Change: 0 B Total Size: 819 kB ℹ️ View Unchanged
|
tjcafferkey
approved these changes
Dec 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
focus: FSE
Work related to prepare WooCommerce for FSE.
focus: template
Related to API powering block template functionality in the Site Editor
skip-changelog
PRs that you don't want to appear in the changelog.
type: bug
The issue/PR concerns a confirmed bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some investigation, we discovered that #5375 introduces a bug on saving template (#5399). So we need partial revert #5375. This PR revert some changes and fixed the new bug.
Testing
Manual Testing
How to test the changes in this Pull Request:
Check out this branch. Be sure that you have:
WordPress 5.9
,Gutenberg trunk version
,WooCommerce 6.0.0
, andWooCommerce Blocks trunk
Template Page
onFull Site Editor
.WooCommerce template
likeSingle Product Page
.Important
This PR reintroduce #5375