This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Trigger validation on change if the input is not focussed #5373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikejolley
added
status: needs review
block: checkout
rubikuserbot
requested review from
a team and
senadir
and removed request for
a team
|
Size Change: +62 B (0%) Total Size: 817 kB
ℹ️ View Unchanged
|
senadir
approved these changes
Dec 13, 2021
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 14, 2021
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #5130 and replaces the fix for #4495.
When browser autofill triggers, from what I can tell with logging, onChange events are fired. However, validation occurs onBlur and this is not fired for autofilled inputs.
Because we can track the onChange event, we can ensure that validation runs (in the background) on non-focused fields.
@senadir this replaces your event handling fix. Does it make more sense to you?
Testing
How to test the changes in this Pull Request:
Changelog