This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Limit CSS styles to WooCommerce Block icons only #5363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielslange
added
type: bug
Aljullu
approved these changes
Dec 10, 2021
There was a problem hiding this comment.
Looks good, thanks for following-up from the previous PR @nielslange! I left a couple of suggestions to simplify the CSS, but pre-approving. 🚢
Co-authored-by: Albert Juhé Lluveras <[email protected]>
|
Size Change: -30 B (0%) Total Size: 817 kB
ℹ️ View Unchanged
|
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 14, 2021
* Limit CSS styles to WooCommerce Block icons only * Update assets/css/editor.scss Co-authored-by: Albert Juhé Lluveras <[email protected]> Co-authored-by: Albert Juhé Lluveras <[email protected]>
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 16, 2021
* Limit CSS styles to WooCommerce Block icons only * Update assets/css/editor.scss Co-authored-by: Albert Juhé Lluveras <[email protected]> Co-authored-by: Albert Juhé Lluveras <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5355
Notes
At the moment, when selecting a block within the List View (Mac:
control + option + o), the icon remains purple (#7F54B3). With the blue background color (#007CBA), the contrast ratio of the icon drops to 1.2:1 (see https://webaim.org/resources/contrastchecker/ or https://color.adobe.com/create/color-contrast-analyzer). This PR is doing the following things:Initially, I thought about adding the CSS class to the
<Icon>component itself rather than the individual elements. However, we're also using icons without a defined color, such as theeyeicon within theViewSwitcherComponent. Therefore, I decided to add the CSS classes to the affected icons itself.Testing
control + option + o).User Facing Testing