This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix required scripts not loading for WC block templates. #5346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubikuserbot
requested review from
a team and
dinhtungdu
and removed request for
a team
tjcafferkey
added
focus: FSE
|
Size Change: 0 B Total Size: 840 kB ℹ️ View Unchanged
|
tjcafferkey
removed
the
skip-changelog
Aljullu
approved these changes
Dec 10, 2021
There was a problem hiding this comment.
I could finally reproduce the issue and I can confirm it fixes it. Good job investigating this, @tjcafferkey!
What are your thoughts on opening an issue in WC core repo so we evaluate loading the scripts somewhere before wp_enqueue_scripts fires?
|
Thanks @Aljullu
Yep, it's on my to do list to create this today 😄 |
5 tasks
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 14, 2021
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 16, 2021
tjcafferkey
added a commit
that referenced
this pull request
Dec 22, 2021
tjcafferkey
added a commit
that referenced
this pull request
Dec 22, 2021
* Empty commit for release pull request * Fix saving WooCommerce templates in WP 5.9 beta 3 (#5408) * fix not found template for the template editor (#5425) * Check for woocommerce as the theme before rendering with a more user friendly plugin name (#5420) * Make it so WooCommerce template names are not editable (#5385) * Make it so WooCommerce template names is not editable * Remove source='plugin' from templates * Load required scripts in LegacyTemplate.php render method (#5346) * Fix reverting WC templates (#5342) * Update block theme conditionals in BlockTemplateController (#5335) * Check if the current theme has a product-archive block template in the absence of a product taxonomy block template. (#5380) * Add archive-product template into block template hieachy * Add archive-product condition to product tag block template render method * Move taxonomy hierarchy filter to WC core * Undo template amends * Duplicate the themes archive-product template if it has one for taxonomy block templates * Review feedback * Use TextDomain instead of Name * use correct if/else syntax * Remove unncessary boolean syntax * Update readme.txt for 6.5.1 changelog * Testing notes for 6.5.1 * Bumping version strings to new version. Co-authored-by: github-actions <[email protected]> Co-authored-by: Albert Juhé Lluveras <[email protected]> Co-authored-by: Luigi Teschio <[email protected]> Co-authored-by: Tom Cafferkey <[email protected]>
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem with WC Core and block templates where we are attempting to enqueue scripts before we've registered them. Meaning they don't get enqueued at all. Read more about this here.
Fixes #5328
Fixes #5329
Testing
Manual Testing
Important: Please check both linked issue and ensure you're able to reproduce them.
How to test the changes in this Pull Request:
User Facing Testing
These are steps for user testing (where "user" is someone interacting with this change that is not editing any code).
Changelog