This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Introduce 2 new hooks in Customer Update Route #5345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubikuserbot
requested review from
a team and
alexflorisca
and removed request for
a team
|
Size Change: -23.6 kB (-3%) Total Size: 817 kB
ℹ️ View Unchanged
|
|
Is there any documentation we should update with these new hooks? Also is there a way to test that these fire correctly? Code looks good, although with a caveat that I haven't done any PHP for 10 years! |
|
@alexflorisca I've added unit tests to confirm the hooks run, and updated hook docs ( |
There was a problem hiding this comment.
Mostly looks good, but there seem to be a bunch of duplicated entries and a lot of changes made to the docs unrelated to the 2 hooks you added here. Can you just have a scan through and double check that everything is good doc wise, and if you're happy, I'm happy to approve.
| } | ||
| }, | ||
| { | ||
| "name": "woocommerce_after_main_content", |
There was a problem hiding this comment.
This is a duplicate of the above. It's also unrelated to the hooks you added in this PR. Is this something that exists but was missing from the docs?
| } | ||
| }, | ||
| { | ||
| "name": "woocommerce_before_main_content", |
There was a problem hiding this comment.
Again this seems to be the same as the one above, with a minor difference in the description and an extra tag. Just checking this is intended?
| { | ||
| "name": "woocommerce_blocks_cart_enqueue_data", | ||
| "file": "BlockTypes/Cart.php", | ||
| "file": "BlockTypes/MiniCart.php", |
There was a problem hiding this comment.
Why has the Cart and MiniCart swapped round here and on the action below?
alexflorisca
approved these changes
Dec 13, 2021
There was a problem hiding this comment.
Discussed in slack (p1639399554056600-slack-C8X6Q7XQU) and decided to ignore the duplicated actions for now (bug reported in #5374)
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 14, 2021
* Introduce woocommerce_blocks_cart_update_customer_from_request hook * Introduce woocommerce_blocks_cart_update_order_from_customer_request * Test actions fire * Update hook docs
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 16, 2021
* Introduce woocommerce_blocks_cart_update_customer_from_request hook * Introduce woocommerce_blocks_cart_update_order_from_customer_request * Test actions fire * Update hook docs
mikejolley
added
the
skip-changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 2 new action hooks to allow vendors to edit order/customer data when customers are updated via the API.
woocommerce_blocks_cart_update_customer_from_request\WC_Customer $customer,\WP_REST_Request $requestwoocommerce_blocks_cart_update_order_from_customer_request\WC_Order $draft_order,\WC_Customer $customer,\WP_REST_Request $requestFixes #5202
Testing
No user facing tests. Unit test coverage added to confirm hooks fire.
Changelog