This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Rollback checkout status to started instead of pristine in case of error #5318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senadir
added
type: bug
|
cc @peterlama you did a lot of debugging in #5296 do you think this solutions cover all of its basis, do you happen to have another approach in mind? @mikejolley you wrote the original code so it's worth giving this another look? |
|
Size Change: +200 B (0%) Total Size: 841 kB
ℹ️ View Unchanged
|
|
@senadir Setting the status to started seems like a good solution to me! Although, I wonder if the status should only be started if a saved payment method is selected? I noticed a check for that here: payment-method-data-context.tsx#L234 |
|
After much consideration, I'm not sure |
|
@senadir As long as we have a way to distinguish |
senadir
force-pushed
the
fix/broken-saved-payment-after-error
branch
from
28a8c8c to
ee764e3
Compare
ralucaStan
reviewed
Dec 8, 2021
| @@ -66,6 +67,8 @@ export interface PaymentMethodDataContextState { | |||
| export type PaymentMethodCurrentStatusType = { | |||
| // If true then the payment method state in checkout is pristine. | |||
| isPristine: boolean; | |||
| // If true then the payment method state in checkout is modified, but isn't doing anyting. | |||
There was a problem hiding this comment.
I find this comment confusing, especially the but isn't doing anyting. part. It's unclear to me what part is not doing anything? Does this idle state for a payment menthod happen when at the same time with this idle status?
ralucaStan
reviewed
Dec 8, 2021
| @@ -222,7 +222,7 @@ export const PaymentMethodDataProvider = ( { | |||
| // When checkout is returned to idle, set payment status to pristine but only if payment status is already not finished. | |||
There was a problem hiding this comment.
This comment also needs updated, just replace pristine with idle here set payment status to pristine but only. It might help to leave some comment with the reason why this is necessary
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checkouts runs into an error (local validation for example), its status is rolled back to pristine, causing payment saved data to unload. For some reasoning, fixing errors and hitting submit again doesn't reset saved payment methods, @alexflorisca and I had two solutions:
Fixes #5296
Testing
How to test the changes in this Pull Request:
Changelog